Merge branch 'simplify-a-bunch-of-ee-plan-tests' into 'master'

Simplify a bunch of Enterprise Edition end-to-end tests

See merge request gitlab-org/gitlab!23174

qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb

@@ -18,8 +18,8 @@ module QA
 
         weight_of_two = 2
 
-        create_issue('Issue 1', milestone.project, milestone, weight_of_two)
-        create_issue('Issue 2', milestone.project, milestone, weight_of_two)
+        create_issue(milestone.project, milestone, weight_of_two)
+        create_issue(milestone.project, milestone, weight_of_two)
       end
 
       it 'shows burndown chart on milestone page' do
@@ -35,10 +35,9 @@ module QA
         end
       end
 
-      def create_issue(title, project, milestone, weight)
+      def create_issue(project, milestone, weight)
         Resource::Issue.fabricate_via_api! do |issue|
           issue.project = project
-          issue.title = title
           issue.milestone = milestone
           issue.weight = weight
         end

qa/qa/specs/features/ee/browser_ui/2_plan/epic/epics_management_spec.rb

@@ -81,7 +81,6 @@ module QA
 
           Resource::Issue.fabricate_via_api! do |issue|
             issue.project = project
-            issue.title = 'Issue created via API'
           end
         end
 

qa/qa/specs/features/ee/browser_ui/2_plan/epic/promote_issue_to_epic_spec.rb

@@ -3,8 +3,6 @@
 module QA
   context 'Plan' do
     describe 'promote issue to epic' do
-      let(:issue_title) { "My Awesome Issue #{SecureRandom.hex(8)}" }
-
       it 'user promotes issue to an epic' do
         Flow::Login.sign_in
 
@@ -14,7 +12,6 @@ module QA
         end
 
         issue = Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = issue_title
           issue.project = project
         end
 
@@ -35,7 +32,7 @@ module QA
         project.group.visit!
         Page::Group::Menu.perform(&:click_group_epics_link)
         QA::EE::Page::Group::Epic::Index.perform do |index|
-          expect(index).to have_epic_title(issue_title)
+          expect(index).to have_epic_title(issue.title)
         end
       end
     end

qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/sum_of_issues_weights_spec.rb

@@ -16,14 +16,12 @@ module QA
 
         Resource::Issue.fabricate_via_api! do |issue|
           issue.project = label_board_list.project
-          issue.title = 'Issue 1'
           issue.labels = [label]
           issue.weight = weight_for_issue_1
         end
 
         Resource::Issue.fabricate_via_api! do |issue|
           issue.project = label_board_list.project
-          issue.title = 'Issue 2'
           issue.labels = [label]
           issue.weight = weight_for_issue_2
         end

qa/qa/specs/features/ee/browser_ui/2_plan/issues_analytics/issues_analytics_spec.rb

@@ -4,9 +4,7 @@ module QA
   context 'Plan' do
     describe 'Issues analytics' do
       let(:issue) do
-        Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = 'Issue to test Issues Analytics'
-        end
+        Resource::Issue.fabricate_via_api!
       end
 
       before do

qa/qa/specs/features/ee/browser_ui/2_plan/issues_list/export_as_csv_spec.rb

@@ -17,7 +17,6 @@ module QA
         2.times do
           Resource::Issue.fabricate_via_api! do |issue|
             issue.project = project
-            issue.title = "Issue-#{SecureRandom.hex(4)}"
           end
         end
 

qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/four_assignees_spec.rb

@@ -21,7 +21,6 @@ module QA
         project.add_member(user_4)
 
         Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = issue.title = 'issue-to-test-multiple-assignees'
           issue.project = project
           issue.assignee_ids = [
             user_1.id,

qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb

@@ -27,7 +27,6 @@ module QA
         project.add_member(user_6)
 
         @issue = Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = issue.title = 'issue-to-test-multiple-assignees'
           issue.project = project
           issue.assignee_ids = [
             user_1.id,

qa/qa/specs/features/ee/browser_ui/2_plan/related_issues/related_issues_spec.rb

@@ -12,14 +12,12 @@ module QA
       let(:issue_1) do
         Resource::Issue.fabricate_via_api! do |issue|
           issue.project = project
-          issue.title = 'Issue 1'
         end
       end
 
       let(:issue_2) do
         Resource::Issue.fabricate_via_api! do |issue|
           issue.project = project
-          issue.title = 'Issue 2'
         end
       end
 

qa/qa/specs/features/ee/browser_ui/2_plan/scoped_labels/editing_scoped_labels_spec.rb

@@ -15,7 +15,6 @@ module QA
         Flow::Login.sign_in
 
         issue = Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = 'Issue to test scoped labels'
           issue.labels = [initial_label, initial_label_multi_colon]
         end