Commit 3f3cdda1 authored by Peter Leitzen's avatar Peter Leitzen

Merge branch 'notification-service-spec' into 'master'

Fix duplicate spec in notification service

See merge request gitlab-org/gitlab!28742
parents f31cdcd6 deda41fb
...@@ -385,4 +385,3 @@ Performance/ChainArrayAllocation: ...@@ -385,4 +385,3 @@ Performance/ChainArrayAllocation:
RSpec/RepeatedExample: RSpec/RepeatedExample:
Exclude: Exclude:
- 'spec/features/merge_request/user_posts_diff_notes_spec.rb' - 'spec/features/merge_request/user_posts_diff_notes_spec.rb'
- 'spec/services/notification_service_spec.rb'
---
title: Update duplicate specs in notification service spec
merge_request: 28742
author: Rajendra Kadam
type: fixed
...@@ -1022,24 +1022,6 @@ describe NotificationService, :mailer do ...@@ -1022,24 +1022,6 @@ describe NotificationService, :mailer do
should_not_email(@u_lazy_participant) should_not_email(@u_lazy_participant)
end end
it 'emails new assignee' do
issue.assignees = [@u_mentioned]
notification.reassigned_issue(issue, @u_disabled, [@u_mentioned])
expect(issue.assignees.first).to be @u_mentioned
should_email(issue.assignees.first)
should_email(@u_watcher)
should_email(@u_guest_watcher)
should_email(@u_guest_custom)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@u_custom_global)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
end
it 'does not email new assignee if they are the current user' do it 'does not email new assignee if they are the current user' do
issue.assignees = [@u_mentioned] issue.assignees = [@u_mentioned]
notification.reassigned_issue(issue, @u_mentioned, [@u_mentioned]) notification.reassigned_issue(issue, @u_mentioned, [@u_mentioned])
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment