Merge branch 'rails-save-bang-23' into 'master'

Fix Rails/SaveBang offenses for spec/models/cycle_analytics*

See merge request gitlab-org/gitlab!41326

.rubocop_todo.yml

@@ -1099,9 +1099,6 @@ Rails/SaveBang:
     - 'spec/models/concerns/subscribable_spec.rb'
     - 'spec/models/concerns/token_authenticatable_spec.rb'
     - 'spec/models/container_repository_spec.rb'
-    - 'spec/models/cycle_analytics/issue_spec.rb'
-    - 'spec/models/cycle_analytics/plan_spec.rb'
-    - 'spec/models/cycle_analytics/production_spec.rb'
     - 'spec/models/deploy_keys_project_spec.rb'
     - 'spec/models/deploy_token_spec.rb'
     - 'spec/models/deployment_spec.rb'

changelogs/unreleased/rails-save-bang-23.yml

+---
+title: Fix Rails/SaveBang offenses for spec/models/cycle_analytics/*
+merge_request: 41326
+author: Rajendra Kadam
+type: fixed

spec/models/cycle_analytics/issue_spec.rb

@@ -15,17 +15,17 @@ RSpec.describe 'CycleAnalytics#issue' do
   generate_cycle_analytics_spec(
     phase: :issue,
     data_fn: -> (context) { { issue: context.build(:issue, project: context.project) } },
-    start_time_conditions: [["issue created", -> (context, data) { data[:issue].save }]],
+    start_time_conditions: [["issue created", -> (context, data) { data[:issue].save! }]],
     end_time_conditions:   [["issue associated with a milestone",
                              -> (context, data) do
                                if data[:issue].persisted?
-                                 data[:issue].update(milestone: context.create(:milestone, project: context.project))
+                                 data[:issue].update!(milestone: context.create(:milestone, project: context.project))
                                end
                              end],
                             ["list label added to issue",
                              -> (context, data) do
                                if data[:issue].persisted?
-                                 data[:issue].update(label_ids: [context.create(:list).label_id])
+                                 data[:issue].update!(label_ids: [context.create(:list).label_id])
                                end
                              end]],
     post_fn: -> (context, data) do
@@ -35,7 +35,7 @@ RSpec.describe 'CycleAnalytics#issue' do
     it "returns nil" do
       regular_label = create(:label)
       issue = create(:issue, project: project)
-      issue.update(label_ids: [regular_label.id])
+      issue.update!(label_ids: [regular_label.id])
 
       create_merge_request_closing_issue(user, project, issue)
       merge_merge_requests_closing_issue(user, project, issue)

spec/models/cycle_analytics/plan_spec.rb

@@ -22,11 +22,11 @@ RSpec.describe 'CycleAnalytics#plan' do
     end,
     start_time_conditions: [["issue associated with a milestone",
                              -> (context, data) do
-                               data[:issue].update(milestone: context.create(:milestone, project: context.project))
+                               data[:issue].update!(milestone: context.create(:milestone, project: context.project))
                              end],
                             ["list label added to issue",
                              -> (context, data) do
-                               data[:issue].update(label_ids: [context.create(:list).label_id])
+                               data[:issue].update!(label_ids: [context.create(:list).label_id])
                              end]],
     end_time_conditions:   [["issue mentioned in a commit",
                              -> (context, data) do
@@ -40,7 +40,7 @@ RSpec.describe 'CycleAnalytics#plan' do
       branch_name = generate(:branch)
       label = create(:label)
       issue = create(:issue, project: project)
-      issue.update(label_ids: [label.id])
+      issue.update!(label_ids: [label.id])
       create_commit_referencing_issue(issue, branch_name: branch_name)
 
       create_merge_request_closing_issue(user, project, issue, source_branch: branch_name)

spec/models/cycle_analytics/production_spec.rb

@@ -15,7 +15,7 @@ RSpec.describe 'CycleAnalytics#production' do
   generate_cycle_analytics_spec(
     phase: :production,
     data_fn: -> (context) { { issue: context.build(:issue, project: context.project) } },
-    start_time_conditions: [["issue is created", -> (context, data) { data[:issue].save }]],
+    start_time_conditions: [["issue is created", -> (context, data) { data[:issue].save! }]],
     before_end_fn: lambda do |context, data|
       context.create_merge_request_closing_issue(context.user, context.project, data[:issue])
       context.merge_merge_requests_closing_issue(context.user, context.project, data[:issue])