Merge branch '32486-update-eslint-plugin-import-to-2.18.2-spec-js-f-i' into 'master'

Update eslint-plugin-import from 2.16.0 to 2.18.2 (/spec/javascripts/[f-i]*)

See merge request gitlab-org/gitlab!21320

spec/javascripts/feature_highlight/feature_highlight_helper_spec.js

 import $ from 'jquery';
 import MockAdapter from 'axios-mock-adapter';
+import getSetTimeoutPromise from 'spec/helpers/set_timeout_promise_helper';
 import axios from '~/lib/utils/axios_utils';
 import { getSelector, dismiss, inserted } from '~/feature_highlight/feature_highlight_helper';
 import { togglePopover } from '~/shared/popover';
 
-import getSetTimeoutPromise from 'spec/helpers/set_timeout_promise_helper';
-
 describe('feature highlight helper', () => {
   describe('getSelector', () => {
     it('returns js-feature-highlight selector', () => {

spec/javascripts/feature_highlight/feature_highlight_spec.js

 import $ from 'jquery';
+import MockAdapter from 'axios-mock-adapter';
 import * as featureHighlight from '~/feature_highlight/feature_highlight';
 import * as popover from '~/shared/popover';
 import axios from '~/lib/utils/axios_utils';
-import MockAdapter from 'axios-mock-adapter';
 
 describe('feature highlight', () => {
   beforeEach(() => {

spec/javascripts/filtered_search/visual_token_value_spec.js

-import VisualTokenValue from '~/filtered_search/visual_token_value';
 import _ from 'underscore';
+import VisualTokenValue from '~/filtered_search/visual_token_value';
 import AjaxCache from '~/lib/utils/ajax_cache';
 import UsersCache from '~/lib/utils/users_cache';
 import DropdownUtils from '~/filtered_search//dropdown_utils';

spec/javascripts/frequent_items/components/app_spec.js

 import MockAdapter from 'axios-mock-adapter';
-import axios from '~/lib/utils/axios_utils';
 import Vue from 'vue';
+import { mountComponentWithStore } from 'spec/helpers/vue_mount_component_helper';
+import axios from '~/lib/utils/axios_utils';
 import appComponent from '~/frequent_items/components/app.vue';
 import eventHub from '~/frequent_items/event_hub';
 import store from '~/frequent_items/store';
 import { FREQUENT_ITEMS, HOUR_IN_MS } from '~/frequent_items/constants';
 import { getTopFrequentItems } from '~/frequent_items/utils';
-import { mountComponentWithStore } from 'spec/helpers/vue_mount_component_helper';
 import { currentSession, mockFrequentProjects, mockSearchedProjects } from '../mock_data';
 
 let session;

spec/javascripts/frequent_items/components/frequent_items_list_item_spec.js

-import frequentItemsListItemComponent from '~/frequent_items/components/frequent_items_list_item.vue';
 import { shallowMount, createLocalVue } from '@vue/test-utils';
 import { trimText } from 'spec/helpers/text_helper';
+import frequentItemsListItemComponent from '~/frequent_items/components/frequent_items_list_item.vue';
 import { mockProject } from '../mock_data'; // can also use 'mockGroup', but not useful to test here
 
 const localVue = createLocalVue();

spec/javascripts/frequent_items/components/frequent_items_list_spec.js

 import Vue from 'vue';
-import frequentItemsListComponent from '~/frequent_items/components/frequent_items_list.vue';
 import mountComponent from 'spec/helpers/vue_mount_component_helper';
+import frequentItemsListComponent from '~/frequent_items/components/frequent_items_list.vue';
 import { mockFrequentProjects } from '../mock_data';
 
 const createComponent = (namespace = 'projects') => {

spec/javascripts/frequent_items/components/frequent_items_search_input_spec.js

+import { shallowMount, createLocalVue } from '@vue/test-utils';
 import searchComponent from '~/frequent_items/components/frequent_items_search_input.vue';
 import eventHub from '~/frequent_items/event_hub';
-import { shallowMount, createLocalVue } from '@vue/test-utils';
 
 const localVue = createLocalVue();
 

spec/javascripts/gpg_badges_spec.js

 import MockAdapter from 'axios-mock-adapter';
+import { TEST_HOST } from 'spec/test_constants';
 import axios from '~/lib/utils/axios_utils';
 import GpgBadges from '~/gpg_badges';
-import { TEST_HOST } from 'spec/test_constants';
 
 describe('GpgBadges', () => {
   let mock;

spec/javascripts/groups/components/group_item_spec.js

 import Vue from 'vue';
+import mountComponent from 'spec/helpers/vue_mount_component_helper';
 import groupItemComponent from '~/groups/components/group_item.vue';
 import groupFolderComponent from '~/groups/components/group_folder.vue';
 import eventHub from '~/groups/event_hub';
-import mountComponent from 'spec/helpers/vue_mount_component_helper';
 import { mockParentGroupItem, mockChildren } from '../mock_data';
 
 const createComponent = (group = mockParentGroupItem, parentGroup = mockChildren[0]) => {

spec/javascripts/groups/components/groups_spec.js

 import Vue from 'vue';
 
+import mountComponent from 'spec/helpers/vue_mount_component_helper';
 import groupsComponent from '~/groups/components/groups.vue';
 import groupFolderComponent from '~/groups/components/group_folder.vue';
 import groupItemComponent from '~/groups/components/group_item.vue';
 import eventHub from '~/groups/event_hub';
-import mountComponent from 'spec/helpers/vue_mount_component_helper';
 import { mockGroups, mockPageInfo } from '../mock_data';
 
 const createComponent = (searchEmpty = false) => {

spec/javascripts/groups/components/item_actions_spec.js

 import Vue from 'vue';
 
+import mountComponent from 'spec/helpers/vue_mount_component_helper';
 import itemActionsComponent from '~/groups/components/item_actions.vue';
 import eventHub from '~/groups/event_hub';
-import mountComponent from 'spec/helpers/vue_mount_component_helper';
 import { mockParentGroupItem, mockChildren } from '../mock_data';
 
 const createComponent = (group = mockParentGroupItem, parentGroup = mockChildren[0]) => {

spec/javascripts/groups/components/item_caret_spec.js

 import Vue from 'vue';
 
-import itemCaretComponent from '~/groups/components/item_caret.vue';
-
 import mountComponent from 'spec/helpers/vue_mount_component_helper';
+import itemCaretComponent from '~/groups/components/item_caret.vue';
 
 const createComponent = (isGroupOpen = false) => {
   const Component = Vue.extend(itemCaretComponent);

spec/javascripts/groups/components/item_stats_spec.js

 import Vue from 'vue';
 
-import itemStatsComponent from '~/groups/components/item_stats.vue';
 import mountComponent from 'spec/helpers/vue_mount_component_helper';
+import itemStatsComponent from '~/groups/components/item_stats.vue';
 import {
   mockParentGroupItem,
   ITEM_TYPE,

spec/javascripts/groups/components/item_stats_value_spec.js

 import Vue from 'vue';
 
-import itemStatsValueComponent from '~/groups/components/item_stats_value.vue';
-
 import mountComponent from 'spec/helpers/vue_mount_component_helper';
+import itemStatsValueComponent from '~/groups/components/item_stats_value.vue';
 
 const createComponent = ({ title, cssClass, iconName, tooltipPlacement, value }) => {
   const Component = Vue.extend(itemStatsValueComponent);

spec/javascripts/groups/components/item_type_icon_spec.js

 import Vue from 'vue';
 
-import itemTypeIconComponent from '~/groups/components/item_type_icon.vue';
 import mountComponent from 'spec/helpers/vue_mount_component_helper';
+import itemTypeIconComponent from '~/groups/components/item_type_icon.vue';
 import { ITEM_TYPE } from '../mock_data';
 
 const createComponent = (itemType = ITEM_TYPE.GROUP, isGroupOpen = false) => {

spec/javascripts/helpers/init_vue_mr_page_helper.js

+import MockAdapter from 'axios-mock-adapter';
 import initMRPage from '~/mr_notes/index';
 import axios from '~/lib/utils/axios_utils';
-import MockAdapter from 'axios-mock-adapter';
 import { userDataMock, notesDataMock, noteableDataMock } from '../notes/mock_data';
 import diffFileMockData from '../diffs/mock_data/diff_file';
 

spec/javascripts/importer_status_spec.js

+import MockAdapter from 'axios-mock-adapter';
 import { ImporterStatus } from '~/importer_status';
 import axios from '~/lib/utils/axios_utils';
-import MockAdapter from 'axios-mock-adapter';
 
 describe('Importer Status', () => {
   let instance;

spec/javascripts/issue_show/components/app_spec.js

 /* eslint-disable no-unused-vars */
-import GLDropdown from '~/gl_dropdown';
 import Vue from 'vue';
 import MockAdapter from 'axios-mock-adapter';
+import setTimeoutPromise from 'spec/helpers/set_timeout_promise_helper';
+import GLDropdown from '~/gl_dropdown';
 import axios from '~/lib/utils/axios_utils';
 import '~/behaviors/markdown/render_gfm';
 import issuableApp from '~/issue_show/components/app.vue';
 import eventHub from '~/issue_show/event_hub';
-import setTimeoutPromise from 'spec/helpers/set_timeout_promise_helper';
 import issueShowData from '../mock_data';
 
 function formatText(text) {

spec/javascripts/issue_show/components/description_spec.js

 import $ from 'jquery';
 import Vue from 'vue';
 import '~/behaviors/markdown/render_gfm';
-import Description from '~/issue_show/components/description.vue';
 import mountComponent from 'spec/helpers/vue_mount_component_helper';
+import Description from '~/issue_show/components/description.vue';
 
 describe('Description component', () => {
   let vm;