Merge branch '228860-resolve-rspec-emptylineafterletblock-qa' into 'master'

Resolve RSpec/EmptyLineAfterLetBlock Exceptions in QA

See merge request gitlab-org/gitlab!38611

.rubocop_todo.yml

@@ -290,22 +290,6 @@ RSpec/ContextWording:
 RSpec/EmptyLineAfterLetBlock:
   Enabled: true
   Exclude:
-    - 'qa/qa/specs/features/api/3_create/repository/changing_repository_storage_spec.rb'
-    - 'qa/qa/specs/features/browser_ui/3_create/gitaly/high_availability_spec.rb'
-    - 'qa/qa/specs/features/browser_ui/3_create/repository/move_project_create_fork_spec.rb'
-    - 'qa/qa/specs/features/browser_ui/5_package/maven_repository_spec.rb'
-    - 'qa/qa/specs/features/browser_ui/5_package/npm_registry_spec.rb'
-    - 'qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_dependent_relationship_spec.rb'
-    - 'qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_independent_relationship_spec.rb'
-    - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb'
-    - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/add_batch_comments_in_merge_request_spec.rb'
-    - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/assign_code_owners_spec.rb'
-    - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb'
-    - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb'
-    - 'qa/qa/specs/features/ee/browser_ui/6_release/multi-project_pipelines_spec.rb'
-    - 'qa/spec/resource/base_spec.rb'
-    - 'qa/spec/resource/events/project_spec.rb'
-    - 'qa/spec/scenario/test/integration/mattermost_spec.rb'
     - 'spec/config/object_store_settings_spec.rb'
     - 'spec/controllers/boards/issues_controller_spec.rb'
     - 'spec/controllers/groups/milestones_controller_spec.rb'

qa/qa/specs/features/browser_ui/3_create/gitaly/high_availability_spec.rb

@@ -9,6 +9,7 @@ module QA
             project.name = 'gitaly_high_availability'
           end
         end
+
         let(:initial_file) { 'pushed_to_primary.txt' }
         let(:final_file) { 'committed_to_primary.txt' }
         let(:praefect_manager) { Service::PraefectManager.new }

qa/qa/specs/features/browser_ui/3_create/repository/move_project_create_fork_spec.rb

@@ -10,6 +10,7 @@ module QA
           project.initialize_with_readme = true
         end
       end
+
       let(:fork_project) do
         Resource::Fork.fabricate_via_api! do |fork|
           fork.user = user

qa/qa/specs/features/browser_ui/5_package/maven_repository_spec.rb

@@ -15,6 +15,7 @@ module QA
 
         Resource::PersonalAccessToken.fabricate!.access_token
       end
+
       let(:project) do
         Resource::Project.fabricate_via_api! do |project|
           project.name = 'maven-package-project'

qa/qa/specs/features/browser_ui/5_package/npm_registry_spec.rb

@@ -14,6 +14,7 @@ module QA
 
         Resource::PersonalAccessToken.fabricate!.access_token
       end
+
       let(:project) do
         Resource::Project.fabricate_via_api! do |project|
           project.name = 'npm-registry-project'

qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_dependent_relationship_spec.rb

@@ -8,6 +8,7 @@ module QA
           project.name = 'pipelines-dependent-relationship'
         end
       end
+
       let!(:runner) do
         Resource::Runner.fabricate_via_api! do |runner|
           runner.project = project

qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_independent_relationship_spec.rb

@@ -8,6 +8,7 @@ module QA
           project.name = 'pipeline-independent-relationship'
         end
       end
+
       let!(:runner) do
         Resource::Runner.fabricate_via_api! do |runner|
           runner.project = project

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb

@@ -58,6 +58,7 @@ module QA
             }
           ]
         end
+
         let(:owner_user) { 'enguser1' }
         let(:sync_users) { ['ENG User 2', 'ENG User 3'] }
 
@@ -108,6 +109,7 @@ module QA
             }
           ]
         end
+
         let(:owner_user) { 'hruser1' }
         let(:sync_users) { ['HR User 2', 'HR User 3'] }
 

qa/qa/specs/features/ee/browser_ui/3_create/merge_request/add_batch_comments_in_merge_request_spec.rb

@@ -8,6 +8,7 @@ module QA
           project.name = 'project-with-merge-request'
         end
       end
+
       let(:merge_request) do
         Resource::MergeRequest.fabricate_via_api! do |merge_request|
           merge_request.title = 'This is a merge request'

qa/qa/specs/features/ee/browser_ui/3_create/repository/assign_code_owners_spec.rb

@@ -13,6 +13,7 @@ module QA
           project.initialize_with_readme = true
         end
       end
+
       let(:branch_name) { 'protected-branch' }
 
       before do

qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb

@@ -11,6 +11,7 @@ module QA
           project_push.commit_message = 'Add README.md'
         end
       end
+
       let(:source_project_uri) { source.project.repository_ssh_location.uri }
       let(:target_project) do
         Resource::Project.fabricate_via_api! do |project|

qa/qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb

@@ -68,6 +68,7 @@ module QA
             group.path = "access-to-protected-branch-#{SecureRandom.hex(8)}"
           end
         end
+
         let(:project) do
           Resource::Project.fabricate_via_api! do |resource|
             resource.name = 'group-with-access-to-protected-branch'

qa/qa/specs/features/ee/browser_ui/6_release/multi-project_pipelines_spec.rb

@@ -12,11 +12,13 @@ module QA
           project.name = upstream_project_name
         end
       end
+
       let(:downstream_project) do
         Resource::Project.fabricate_via_api! do |project|
           project.name = downstream_project_name
         end
       end
+
       let!(:runner) do
         Resource::Runner.fabricate_via_api! do |runner|
           runner.project = upstream_project

qa/spec/resource/base_spec.rb

@@ -226,6 +226,7 @@ describe QA::Resource::Base do
           end
         end
       end
+
       let(:first_resource) do
         Class.new(base) do
           attribute :test do
@@ -233,6 +234,7 @@ describe QA::Resource::Base do
           end
         end
       end
+
       let(:second_resource) do
         Class.new(base) do
           attribute :test do

qa/spec/resource/events/project_spec.rb

@@ -8,6 +8,7 @@ describe QA::Resource::Events::Project do
       end
     end
   end
+
   let(:all_events) do
     [
       {

qa/spec/scenario/test/integration/mattermost_spec.rb

@@ -10,6 +10,7 @@ describe QA::Scenario::Test::Integration::Mattermost do
           mattermost_address: 'http://mattermost_address'
         }
       end
+
       let(:named_options) { %w[--address http://gitlab_address --mattermost-address http://mattermost_address] }
       let(:tags) { [:mattermost] }
       let(:options) { ['path1']}