Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4651e2c9
Commit
4651e2c9
authored
Apr 22, 2020
by
Alper Akgun
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix security discovery carousel slider event value
It should use the property which accepts non numeric
parent
d786db36
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
1 deletion
+13
-1
ee/app/assets/javascripts/vue_shared/discover/card_security_discover_app.vue
...cripts/vue_shared/discover/card_security_discover_app.vue
+1
-1
ee/spec/frontend/vue_shared/discover/card_security_discover_app_spec.js
...nd/vue_shared/discover/card_security_discover_app_spec.js
+12
-0
No files found.
ee/app/assets/javascripts/vue_shared/discover/card_security_discover_app.vue
View file @
4651e2c9
...
...
@@ -77,7 +77,7 @@ export default {
onSlideStart
(
slide
)
{
this
.
track
(
'
click_button
'
,
{
label
:
'
security-discover-carousel
'
,
value
:
`sliding
${
this
.
slide
}
-
${
slide
}
`
,
property
:
`sliding
${
this
.
slide
}
-
${
slide
}
`
,
});
this
.
textSlide
=
slide
;
},
...
...
ee/spec/frontend/vue_shared/discover/card_security_discover_app_spec.js
View file @
4651e2c9
...
...
@@ -78,6 +78,18 @@ describe('Card security discover app', () => {
});
});
it
(
'
tracks an event when clicked on a slider
'
,
()
=>
{
const
expectedCategory
=
undefined
;
document
.
body
.
dataset
.
page
=
'
_category_
'
;
wrapper
.
vm
.
onSlideStart
(
1
);
expect
(
spy
).
toHaveBeenCalledWith
(
expectedCategory
,
'
click_button
'
,
{
label
:
'
security-discover-carousel
'
,
property
:
'
sliding0-1
'
,
});
});
it
(
'
tracks an event when clicked on feedback
'
,
()
=>
{
wrapper
.
find
(
'
.discover-feedback-icon
'
).
trigger
(
'
click
'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment