Translate strings, change other to generic

Mark messages for translation
Rename otherError to genericError

app/assets/javascripts/pipeline_new/constants.js

+import { __ } from '~/locale';
 import { DEFAULT_DEBOUNCE_AND_THROTTLE_MS } from '~/lib/utils/constants';
 
 export const VARIABLE_TYPE = 'env_var';
@@ -7,5 +8,7 @@ export const CONFIG_VARIABLES_TIMEOUT = 5000;
 export const BRANCH_REF_TYPE = 'branch';
 export const TAG_REF_TYPE = 'tag';
 
-export const CC_VALIDATION_REQUIRED_ERROR =
-  'Credit card required to be on file in order to create a pipeline';
+// must match pipeline/chain/validate/after_config.rb
+export const CC_VALIDATION_REQUIRED_ERROR = __(
+  'Credit card required to be on file in order to create a pipeline',
+);

app/assets/javascripts/projects/settings/components/shared_runners_toggle.vue

@@ -51,7 +51,7 @@ export default {
     ccRequiredError() {
       return this.errorMessage === CC_VALIDATION_REQUIRED_ERROR && !this.ccAlertDismissed;
     },
-    otherError() {
+    genericError() {
       return (
         this.errorMessage &&
         this.errorMessage !== CC_VALIDATION_REQUIRED_ERROR &&
@@ -94,7 +94,7 @@ export default {
         @dismiss="ccAlertDismissed = true"
       />
 
-      <gl-alert v-if="otherError" class="gl-mb-3" variant="danger" :dismissible="false">
+      <gl-alert v-if="genericError" class="gl-mb-3" variant="danger" :dismissible="false">
         {{ errorMessage }}
       </gl-alert>
 

app/assets/javascripts/projects/settings/constants.js

+import { __ } from '~/locale';
+
 export const LEVEL_TYPES = {
   ROLE: 'role',
   USER: 'user',
@@ -20,5 +22,6 @@ export const ACCESS_LEVELS = {
 export const ACCESS_LEVEL_NONE = 0;
 
 // must match shared_runners_setting in update_service.rb
-export const CC_VALIDATION_REQUIRED_ERROR =
-  'Shared runners enabled cannot be enabled until a valid credit card is on file';
+export const CC_VALIDATION_REQUIRED_ERROR = __(
+  'Shared runners enabled cannot be enabled until a valid credit card is on file',
+);

locale/gitlab.pot

@@ -10447,6 +10447,9 @@ msgstr ""
 msgid "CredentialsInventory|SSH Keys"
 msgstr ""
 
+msgid "Credit card required to be on file in order to create a pipeline"
+msgstr ""
+
 msgid "Credit card:"
 msgstr ""
 
@@ -33045,6 +33048,9 @@ msgstr ""
 msgid "Shared runners details"
 msgstr ""
 
+msgid "Shared runners enabled cannot be enabled until a valid credit card is on file"
+msgstr ""
+
 msgid "Shared runners help link"
 msgstr ""