Merge branch 'fix-wrong-productivity-analytics-response-code' into 'master'

Use 403 when PA licensed feature is not available

See merge request gitlab-org/gitlab!16594

ee/app/controllers/analytics/productivity_analytics_controller.rb

@@ -52,8 +52,8 @@ class Analytics::ProductivityAnalyticsController < Analytics::ApplicationControl
   end
 
   def check_feature_availability!
-    return render_404 unless ::License.feature_available?(:productivity_analytics)
-    return render_404 if @group && !@group.root_ancestor.feature_available?(:productivity_analytics)
+    return render_403 unless ::License.feature_available?(:productivity_analytics)
+    return render_403 if @group && !@group.root_ancestor.feature_available?(:productivity_analytics)
   end
 
   def load_group

ee/spec/controllers/analytics/productivity_analytics_controller_spec.rb

@@ -43,7 +43,7 @@ describe Analytics::ProductivityAnalyticsController do
 
       subject
 
-      expect(response).to have_gitlab_http_status(404)
+      expect(response).to have_gitlab_http_status(403)
     end
 
     it 'authorizes for ability to view analytics' do