Merge branch '211607-offset-pagination' into 'master'

GraphQL: Refactor OffsetActiveRecordRelationConnection to use new GraphQL::Pagination class

See merge request gitlab-org/gitlab!27459

lib/gitlab/graphql/connections.rb

@@ -16,10 +16,6 @@ module Gitlab
           Gitlab::Graphql::ExternallyPaginatedArray,
           Gitlab::Graphql::Connections::ExternallyPaginatedArrayConnection
         )
-        GraphQL::Relay::BaseConnection.register_connection_implementation(
-          Gitlab::Graphql::Pagination::Relations::OffsetActiveRecordRelation,
-          Gitlab::Graphql::Pagination::OffsetActiveRecordRelationConnection
-        )
       end
     end
   end

lib/gitlab/graphql/pagination/offset_active_record_relation_connection.rb

@@ -6,7 +6,7 @@
 module Gitlab
   module Graphql
     module Pagination
-      class OffsetActiveRecordRelationConnection < GraphQL::Relay::RelationConnection
+      class OffsetActiveRecordRelationConnection < GraphQL::Pagination::ActiveRecordRelationConnection
       end
     end
   end

lib/gitlab/graphql/pagination/relations/offset_active_record_relation.rb

-# frozen_string_literal: true
-
-module Gitlab
-  module Graphql
-    module Pagination
-      module Relations
-        class OffsetActiveRecordRelation < ::ActiveRecord::Relation
-        end
-      end
-    end
-  end
-end

spec/graphql/gitlab_schema_spec.rb

@@ -52,12 +52,6 @@ describe GitlabSchema do
     expect(connection).to eq(Gitlab::Graphql::Connections::FilterableArrayConnection)
   end
 
-  it 'paginates OffsetActiveRecordRelation using `Pagination::OffsetActiveRecordRelationConnection`' do
-    connection = implementations[Gitlab::Graphql::Pagination::Relations::OffsetActiveRecordRelation.name]
-
-    expect(connection).to eq(Gitlab::Graphql::Pagination::OffsetActiveRecordRelationConnection)
-  end
-
   describe '.execute' do
     context 'for different types of users' do
       context 'when no context' do

spec/lib/gitlab/graphql/pagination/offset_active_record_relation_connection_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 describe Gitlab::Graphql::Pagination::OffsetActiveRecordRelationConnection do
   it 'subclasses from GraphQL::Relay::RelationConnection' do
-    expect(described_class.superclass).to eq GraphQL::Relay::RelationConnection
+    expect(described_class.superclass).to eq GraphQL::Pagination::ActiveRecordRelationConnection
   end
 end