Merge branch '6575-extract-ee-specific-files-lines-for-spec-features-security' into 'master'

Resolve "Extract EE specific files/lines for spec/features/security"

Closes #6575

See merge request gitlab-org/gitlab-ee!13379

ee/spec/features/security/admin_access_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Admin::Projects" do
+  include AccessMatchers
+
+  describe "GET /admin/projects" do
+    subject { admin_projects_path }
+
+    it { is_expected.to be_denied_for :auditor }
+  end
+
+  describe "GET /admin/users" do
+    subject { admin_users_path }
+
+    it { is_expected.to be_denied_for :auditor }
+  end
+
+  describe "GET /admin/hooks" do
+    subject { admin_hooks_path }
+
+    it { is_expected.to be_denied_for :auditor }
+  end
+end

ee/spec/features/security/dashboard_access_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Dashboard access" do
+  include AccessMatchers
+
+  describe "GET /dashboard" do
+    subject { dashboard_projects_path }
+
+    it { is_expected.to be_allowed_for :auditor }
+  end
+
+  describe "GET /dashboard/issues" do
+    subject { issues_dashboard_path }
+
+    it { is_expected.to be_allowed_for :auditor }
+  end
+
+  describe "GET /dashboard/merge_requests" do
+    subject { merge_requests_dashboard_path }
+
+    it { is_expected.to be_allowed_for :auditor }
+  end
+
+  describe "GET /dashboard/projects/starred" do
+    subject { starred_dashboard_projects_path }
+
+    it { is_expected.to be_allowed_for :auditor }
+  end
+
+  describe "GET /help" do
+    subject { help_path }
+
+    it { is_expected.to be_allowed_for :auditor }
+  end
+
+  describe "GET /projects/new" do
+    it { expect(new_project_path).to be_allowed_for :auditor }
+  end
+
+  describe "GET /groups/new" do
+    it { expect(new_group_path).to be_allowed_for :auditor }
+  end
+
+  describe "GET /profile/groups" do
+    subject { dashboard_groups_path }
+
+    it { is_expected.to be_allowed_for :auditor }
+  end
+end

spec/features/security/admin_access_spec.rb

@@ -9,7 +9,6 @@ describe "Admin::Projects" do
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_denied_for :user }
     it { is_expected.to be_denied_for :visitor }
-    it { is_expected.to be_denied_for :auditor }
   end
 
   describe "GET /admin/users" do
@@ -18,7 +17,6 @@ describe "Admin::Projects" do
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_denied_for :user }
     it { is_expected.to be_denied_for :visitor }
-    it { is_expected.to be_denied_for :auditor }
   end
 
   describe "GET /admin/hooks" do
@@ -27,6 +25,5 @@ describe "Admin::Projects" do
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_denied_for :user }
     it { is_expected.to be_denied_for :visitor }
-    it { is_expected.to be_denied_for :auditor }
   end
 end

spec/features/security/dashboard_access_spec.rb

@@ -8,7 +8,6 @@ describe "Dashboard access" do
 
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_allowed_for :user }
-    it { is_expected.to be_allowed_for :auditor }
     it { is_expected.to be_denied_for :visitor }
   end
 
@@ -17,7 +16,6 @@ describe "Dashboard access" do
 
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_allowed_for :user }
-    it { is_expected.to be_allowed_for :auditor }
     it { is_expected.to be_denied_for :visitor }
   end
 
@@ -26,7 +24,6 @@ describe "Dashboard access" do
 
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_allowed_for :user }
-    it { is_expected.to be_allowed_for :auditor }
     it { is_expected.to be_denied_for :visitor }
   end
 
@@ -35,7 +32,6 @@ describe "Dashboard access" do
 
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_allowed_for :user }
-    it { is_expected.to be_allowed_for :auditor }
     it { is_expected.to be_denied_for :visitor }
   end
 
@@ -44,21 +40,18 @@ describe "Dashboard access" do
 
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_allowed_for :user }
-    it { is_expected.to be_allowed_for :auditor }
     it { is_expected.to be_allowed_for :visitor }
   end
 
   describe "GET /projects/new" do
     it { expect(new_project_path).to be_allowed_for :admin }
     it { expect(new_project_path).to be_allowed_for :user }
-    it { expect(new_project_path).to be_allowed_for :auditor }
     it { expect(new_project_path).to be_denied_for :visitor }
   end
 
   describe "GET /groups/new" do
     it { expect(new_group_path).to be_allowed_for :admin }
     it { expect(new_group_path).to be_allowed_for :user }
-    it { expect(new_group_path).to be_allowed_for :auditor }
     it { expect(new_group_path).to be_denied_for :visitor }
   end
 
@@ -67,7 +60,6 @@ describe "Dashboard access" do
 
     it { is_expected.to be_allowed_for :admin }
     it { is_expected.to be_allowed_for :user }
-    it { is_expected.to be_allowed_for :auditor }
     it { is_expected.to be_denied_for :visitor }
   end
 end