Update QA selectors and remove old tests

Removes the older haml spec tests, these
will be replaced with vuejs tests.

app/assets/javascripts/groups/components/transfer_group_form.vue

@@ -76,16 +76,11 @@ export default {
         :default-text="$options.i18n.dropdownTitle"
         :data="parentGroups"
         :empty-namespace-title="$options.i18n.emptyNamespaceTitle"
+        :include-headers="false"
         include-empty-namespace
-        include-headers
         @select="handleSelected"
       />
-      <input
-        id="new_parent_group_id"
-        type="hidden"
-        name="new_parent_group_id"
-        :value="selectedId"
-      />
+      <input type="hidden" name="new_parent_group_id" :value="selectedId" />
     </gl-form-group>
     <gl-alert v-if="isPaidGroup" class="gl-mb-5">
       <gl-sprintf :message="$options.i18n.paidGroupMessage">

app/assets/javascripts/vue_shared/components/namespace_select/namespace_select.vue

@@ -8,6 +8,7 @@ import {
 } from '@gitlab/ui';
 import { __ } from '~/locale';
 
+export const EMPTY_NAMESPACE_ID = -1
 export const i18n = {
   DEFAULT_TEXT: __('Select a new namespace'),
   DEFAULT_EMPTY_NAMESPACE_TEXT: __('No namespace'),
@@ -45,7 +46,7 @@ export default {
     includeHeaders: {
       type: Boolean,
       required: false,
-      default: false,
+      default: true,
     },
     emptyNamespaceTitle: {
       type: String,
@@ -95,7 +96,7 @@ export default {
       this.$emit('select', item);
     },
     handleSelectEmptyNamespace() {
-      this.handleSelect({ id: -1, humanName: this.emptyNamespace });
+      this.handleSelect({ id: EMPTY_NAMESPACE_ID, humanName: this.emptyNamespace });
     },
   },
   i18n,

ee/spec/views/groups/settings/_transfer.html.haml_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe 'groups/settings/_transfer.html.haml' do
-  describe 'render' do
-    let(:group) { create(:group) }
-
-    it 'enables the Select parent group dropdown and does not show an alert for a group' do
-      render 'groups/settings/transfer', group: group
-
-      expect(rendered).to have_button 'Select parent group'
-      expect(rendered).not_to have_button 'Select parent group', disabled: true
-      expect(rendered).not_to have_text "This group can't be transfered because it is linked to a subscription."
-    end
-
-    it 'disables the Select parent group dropdown and shows an alert for a group with a paid gitlab.com plan', :saas do
-      create(:gitlab_subscription, :ultimate, namespace: group)
-
-      render 'groups/settings/transfer', group: group
-
-      expect(rendered).to have_button 'Select parent group', disabled: true
-      expect(rendered).to have_text "This group can't be transfered because it is linked to a subscription."
-    end
-
-    it 'enables the Select parent group dropdown and does not show an alert for a subgroup', :saas do
-      create(:gitlab_subscription, :ultimate, namespace: group)
-      subgroup = create(:group, parent: group)
-
-      render 'groups/settings/transfer', group: subgroup
-
-      expect(rendered).to have_button 'Select parent group'
-      expect(rendered).not_to have_button 'Select parent group', disabled: true
-      expect(rendered).not_to have_text "This group can't be transfered because it is linked to a subscription."
-    end
-  end
-end

locale/gitlab.pot

@@ -17289,9 +17289,6 @@ msgstr ""
 msgid "GroupSettings|Overrides user notification preferences for all members of the group, subgroups, and projects."
 msgstr ""
 
-msgid "GroupSettings|Parent Group"
-msgstr ""
-
 msgid "GroupSettings|Pipeline settings was updated for the group"
 msgstr ""
 
@@ -17319,9 +17316,6 @@ msgstr ""
 msgid "GroupSettings|Projects will be permanently deleted after a %{waiting_period}-day delay. This delay can be %{link_start}customized by an admin%{link_end} in instance settings. Inherited by subgroups."
 msgstr ""
 
-msgid "GroupSettings|Search groups"
-msgstr ""
-
 msgid "GroupSettings|Select a project with the %{code_start}.gitlab/insights.yml%{code_end} file"
 msgstr ""
 
@@ -17352,6 +17346,9 @@ msgstr ""
 msgid "GroupSettings|There was a problem updating the pipeline settings: %{error_messages}."
 msgstr ""
 
+msgid "GroupSettings|This group can't be transfered because it is linked to a subscription. To transfer this group, %{linkStart}link the subscription%{linkEnd} with a different group."
+msgstr ""
+
 msgid "GroupSettings|This setting is applied on %{ancestor_group} and has been overridden on this subgroup."
 msgstr ""
 
@@ -24210,6 +24207,9 @@ msgstr ""
 msgid "No milestones to show"
 msgstr ""
 
+msgid "No namespace"
+msgstr ""
+
 msgid "No other labels with such name or description"
 msgstr ""
 
@@ -36629,9 +36629,6 @@ msgstr ""
 msgid "This group can't be removed because it is linked to a subscription. To remove this group, %{linkStart}link the subscription%{linkEnd} with a different group."
 msgstr ""
 
-msgid "This group can't be transfered because it is linked to a subscription. To transfer this group, %{linkStart}link the subscription%{linkEnd} with a different group."
-msgstr ""
-
 msgid "This group cannot be invited to a project inside a group with enforced SSO"
 msgstr ""
 
@@ -40861,6 +40858,9 @@ msgstr ""
 msgid "You are going to remove the fork relationship from %{project_full_name}. Are you ABSOLUTELY sure?"
 msgstr ""
 
+msgid "You are going to transfer %{group_name} to another namespace. Are you ABSOLUTELY sure?"
+msgstr ""
+
 msgid "You are going to transfer %{project_full_name} to another namespace. Are you ABSOLUTELY sure?"
 msgstr ""
 

qa/qa/page/group/settings/general.rb

@@ -7,6 +7,7 @@ module QA
         class General < QA::Page::Base
           include ::QA::Page::Settings::Common
           include Page::Component::VisibilitySetting
+          include Page::Component::ConfirmModal
 
           view 'app/views/groups/edit.html.haml' do
             element :permission_lfs_2fa_content
@@ -39,7 +40,6 @@ module QA
           end
 
           view 'app/views/groups/settings/_transfer.html.haml' do
-            element :select_group_dropdown
             element :transfer_group_button
           end
 
@@ -48,6 +48,10 @@ module QA
             element :dropdown_list_content
           end
 
+          view 'app/assets/javascripts/groups/components/transfer_group_form.vue' do
+            element :select_group_dropdown
+          end
+
           def set_group_name(name)
             find_element(:group_name_field).send_keys([:command, 'a'], :backspace)
             find_element(:group_name_field).set name
@@ -122,6 +126,9 @@ module QA
             end
 
             click_element :transfer_group_button
+
+            fill_confirmation_text(target_group)
+            confirm_transfer
           end
         end
       end

spec/frontend/vue_shared/components/namespace_select/namespace_select_spec.js

@@ -2,6 +2,7 @@ import { GlDropdown, GlDropdownItem, GlDropdownSectionHeader } from '@gitlab/ui'
 import { shallowMountExtended } from 'helpers/vue_test_utils_helper';
 import NamespaceSelect, {
   i18n,
+  EMPTY_NAMESPACE_ID,
 } from '~/vue_shared/components/namespace_select/namespace_select.vue';
 import { user, group, namespaces } from './mock_data';
 
@@ -36,6 +37,12 @@ describe('Namespace Select', () => {
     expect(findDropdown().exists()).toBe(true);
   });
 
+  it('can override the default text', () => {
+    const textOverride = 'Select an option';
+    wrapper = createComponent({ defaultText: textOverride });
+    expect(selectedDropdownItemText()).toBe(textOverride);
+  });
+
   it('renders each dropdown item', () => {
     const items = findDropdownItems().wrappers;
     expect(items).toHaveLength(flatNamespaces().length);
@@ -57,6 +64,11 @@ describe('Namespace Select', () => {
     expect(wrappersText(headers)).toEqual([i18n.GROUPS, i18n.USERS]);
   });
 
+  it('can hide the group / user headers', () => {
+    wrapper = createComponent({ includeHeaders: false });
+    expect(findSectionHeaders()).toHaveLength(0);
+  });
+
   it('sets the dropdown to full width', () => {
     expect(findDropdownAttributes('block')).toBeUndefined();
 
@@ -83,4 +95,29 @@ describe('Namespace Select', () => {
       expect(wrapper.emitted('select')).toEqual([args]);
     });
   });
+
+  describe('with an empty namespace option', () => {
+    const emptyNamespaceTitle = 'No namespace selected';
+
+    beforeEach(() => {
+      wrapper = createComponent({
+        includeEmptyNamespace: true,
+        emptyNamespaceTitle,
+      });
+      return wrapper.vm.$nextTick();
+    });
+
+    it('includes the empty namespace', () => {
+      const first = findDropdownItems().at(0);
+      expect(first.text()).toBe(emptyNamespaceTitle);
+    });
+
+    it('emits the `select` event when a namespace is selected', () => {
+      findDropdownItems().at(0).vm.$emit('click');
+
+      expect(wrapper.emitted('select')).toEqual([
+        [{ id: EMPTY_NAMESPACE_ID, humanName: emptyNamespaceTitle }],
+      ]);
+    });
+  });
 });

spec/views/groups/settings/_transfer.html.haml_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe 'groups/settings/_transfer.html.haml' do
-  describe 'render' do
-    it 'enables the Select parent group dropdown and does not show an alert for a group' do
-      group = build(:group)
-
-      render 'groups/settings/transfer', group: group
-
-      expect(rendered).to have_button 'Select parent group'
-      expect(rendered).not_to have_button 'Select parent group', disabled: true
-      expect(rendered).not_to have_text "This group can't be transfered because it is linked to a subscription."
-    end
-  end
-end