Commit 4add03ac authored by Aakriti Gupta's avatar Aakriti Gupta

Don't return boolean for oauth on Geo primary

parent a4d3e18f
---
title: 'Geo: Fix OAuth failure on primary'
merge_request: 47178
author:
type: fixed
......@@ -88,7 +88,7 @@ module Gitlab
end
def self.oauth_authentication
return false unless Gitlab::Geo.secondary?
return unless Gitlab::Geo.secondary?
self.cache_value(:oauth_application) do
Gitlab::Geo.current_node.oauth_application || raise(OauthApplicationUndefinedError)
......
......@@ -143,12 +143,24 @@ RSpec.describe Gitlab::Geo, :geo, :request_store do
end
describe '.oauth_authentication' do
before do
stub_secondary_node
stub_current_geo_node(secondary_node)
context 'for Geo secondary' do
before do
stub_secondary_node
stub_current_geo_node(secondary_node)
end
it_behaves_like 'a Geo cached value', :oauth_authentication, :oauth_application
end
it_behaves_like 'a Geo cached value', :oauth_authentication, :oauth_application
context 'for Geo primary' do
before do
stub_current_geo_node(primary_node)
end
it 'returns nil' do
expect(described_class.oauth_authentication).to be_nil
end
end
end
describe '.connected?' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment