Streamline icons in UI

Replacing the 'issue-created' icon with the 'issues' icon. Merge
requests use the default icon when one has been created, and this
will follow that pattern. This also helps clean up the icon library.

changelogs/unreleased/208831-replace-issue-created-icon-with-issues.yml

+---
+title: Replace issue-created icon with issues icon
+merge_request: 26409
+author:
+type: other

ee/app/assets/javascripts/security_dashboard/components/vulnerability_issue_link.vue

@@ -31,7 +31,7 @@ export default {
   <div class="d-inline">
     <gl-icon
       v-gl-tooltip
-      name="issue-created"
+      name="issues"
       class="text-success vertical-align-middle"
       :title="s__('SecurityReports|Issue Created')"
     />

ee/app/assets/javascripts/vue_shared/security_reports/components/issue_note.vue

@@ -36,7 +36,7 @@ export default {
 </script>
 
 <template>
-  <event-item :author="feedback.author" :created-at="feedback.created_at" icon-name="issue-created">
+  <event-item :author="feedback.author" :created-at="feedback.created_at" icon-name="issues">
     <gl-sprintf :message="eventText">
       <template #issueLink>
         <gl-link :href="feedback.issue_url">#{{ feedback.issue_iid }}</gl-link>

ee/spec/frontend/security_dashboard/components/security_dashboard_table_row_spec.js

@@ -36,7 +36,7 @@ describe('Security Dashboard Table Row', () => {
 
   const findLoader = () => wrapper.find('.js-skeleton-loader');
   const findContent = i => wrapper.findAll('.table-mobile-content').at(i);
-  const findAllIssueCreated = () => wrapper.findAll('[data-testid="issue-created-icon"]');
+  const findAllIssueCreated = () => wrapper.findAll('[data-testid="issues-icon"]');
   const hasSelectedClass = () => wrapper.classes('gl-bg-blue-50');
   const findCheckbox = () => wrapper.find(GlFormCheckbox);
 
@@ -173,7 +173,7 @@ describe('Security Dashboard Table Row', () => {
       createComponent(mount, { props: { vulnerability } });
     });
 
-    it('should have a `issue-created` icon', () => {
+    it('should have a `issues` icon', () => {
       expect(findAllIssueCreated()).toHaveLength(1);
     });
   });
@@ -185,7 +185,7 @@ describe('Security Dashboard Table Row', () => {
       createComponent(mount, { props: { vulnerability } });
     });
 
-    it('should not have a `issue-created` icon', () => {
+    it('should not have a `issues` icon', () => {
       expect(findAllIssueCreated()).toHaveLength(0);
     });
   });
@@ -197,7 +197,7 @@ describe('Security Dashboard Table Row', () => {
       createComponent(shallowMount, { props: { vulnerability } });
     });
 
-    it('should not have a `issue-created` icon', () => {
+    it('should not have a `issues` icon', () => {
       expect(findAllIssueCreated()).toHaveLength(0);
     });