Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4b777db1
Commit
4b777db1
authored
Jan 17, 2020
by
Jennie Louie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Check for minimal count of performance bar metrics
parent
c9c86caa
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
qa/qa/page/layout/performance_bar.rb
qa/qa/page/layout/performance_bar.rb
+2
-2
qa/qa/specs/features/browser_ui/non_devops/performance_bar_spec.rb
...cs/features/browser_ui/non_devops/performance_bar_spec.rb
+3
-3
No files found.
qa/qa/page/layout/performance_bar.rb
View file @
4b777db1
...
...
@@ -21,9 +21,9 @@ module QA
has_element?
(
:performance_bar
)
end
def
has_detailed_metrics?
(
count
)
def
has_detailed_metrics?
(
minimum_
count
)
retry_until
(
sleep_interval:
1
)
do
all_elements
(
:detailed_metric_content
,
count:
count
).
all?
do
|
metric
|
all_elements
(
:detailed_metric_content
,
minimum:
minimum_
count
).
all?
do
|
metric
|
metric
.
has_text?
(
%r{
\d
+}
)
end
end
...
...
qa/qa/specs/features/browser_ui/non_devops/performance_bar_spec.rb
View file @
4b777db1
...
...
@@ -4,8 +4,8 @@ module QA
context
'Non-devops'
do
describe
'Performance bar display'
,
:requires_admin
do
context
'when logged in as an admin user'
do
#
4 metrics: pg, gitaly, redis, total
let
(
:m
etrics_count
)
{
4
}
#
performance metrics: pg, gitaly, redis, rugged (feature flagged), total (not always provided)
let
(
:m
inimum_metrics_count
)
{
3
}
before
do
Flow
::
Login
.
sign_in_as_admin
...
...
@@ -28,7 +28,7 @@ module QA
Page
::
Layout
::
PerformanceBar
.
perform
do
|
bar_component
|
expect
(
bar_component
).
to
have_performance_bar
expect
(
bar_component
).
to
have_detailed_metrics
(
metrics_count
)
expect
(
bar_component
).
to
have_detailed_metrics
(
m
inimum_m
etrics_count
)
expect
(
bar_component
).
to
have_request_for
(
'realtime_changes'
)
# Always requested on issue pages
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment