Commit 4badc4a8 authored by Kerri Miller's avatar Kerri Miller

Merge branch 'rspec-empty-line-after-letitbe-ee-spec-services-projects' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/projects

See merge request gitlab-org/gitlab!58330
parents 4478c1ad 370ca918
...@@ -513,12 +513,6 @@ RSpec/EmptyLineAfterFinalLetItBe: ...@@ -513,12 +513,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
- ee/spec/services/merge_request_approval_settings/update_service_spec.rb - ee/spec/services/merge_request_approval_settings/update_service_spec.rb
- ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb - ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb
- ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb - ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb
- ee/spec/services/projects/after_rename_service_spec.rb
- ee/spec/services/projects/alerting/notify_service_spec.rb
- ee/spec/services/projects/destroy_service_spec.rb
- ee/spec/services/projects/gitlab_projects_import_service_spec.rb
- ee/spec/services/projects/import_export/export_service_spec.rb
- ee/spec/services/projects/transfer_service_spec.rb
- ee/spec/services/push_rules/create_or_update_service_spec.rb - ee/spec/services/push_rules/create_or_update_service_spec.rb
- ee/spec/services/quality_management/test_cases/create_service_spec.rb - ee/spec/services/quality_management/test_cases/create_service_spec.rb
- ee/spec/services/quick_actions/interpret_service_spec.rb - ee/spec/services/quick_actions/interpret_service_spec.rb
......
---
title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/projects
merge_request: 58330
author: Abdul Wadood @abdulwd
type: fixed
...@@ -9,6 +9,7 @@ RSpec.describe Projects::AfterRenameService do ...@@ -9,6 +9,7 @@ RSpec.describe Projects::AfterRenameService do
context 'when running on a primary node' do context 'when running on a primary node' do
let_it_be(:primary) { create(:geo_node, :primary) } let_it_be(:primary) { create(:geo_node, :primary) }
let_it_be(:secondary) { create(:geo_node) } let_it_be(:secondary) { create(:geo_node) }
let(:project) { create(:project, :repository, :legacy_storage) } let(:project) { create(:project, :repository, :legacy_storage) }
let!(:path_before_rename) { project.path } let!(:path_before_rename) { project.path }
let!(:full_path_before_rename) { project.full_path } let!(:full_path_before_rename) { project.full_path }
......
...@@ -7,6 +7,7 @@ RSpec.describe Projects::Alerting::NotifyService do ...@@ -7,6 +7,7 @@ RSpec.describe Projects::Alerting::NotifyService do
describe '#execute' do describe '#execute' do
let_it_be(:integration) { create(:alert_management_http_integration, project: project) } let_it_be(:integration) { create(:alert_management_http_integration, project: project) }
let(:service) { described_class.new(project, payload) } let(:service) { described_class.new(project, payload) }
let(:token) { integration.token } let(:token) { integration.token }
let(:payload) do let(:payload) do
...@@ -68,6 +69,7 @@ RSpec.describe Projects::Alerting::NotifyService do ...@@ -68,6 +69,7 @@ RSpec.describe Projects::Alerting::NotifyService do
let_it_be(:schedule) { create(:incident_management_oncall_schedule, project: project) } let_it_be(:schedule) { create(:incident_management_oncall_schedule, project: project) }
let_it_be(:rotation) { create(:incident_management_oncall_rotation, schedule: schedule) } let_it_be(:rotation) { create(:incident_management_oncall_rotation, schedule: schedule) }
let_it_be(:participant) { create(:incident_management_oncall_participant, :with_developer_access, rotation: rotation) } let_it_be(:participant) { create(:incident_management_oncall_participant, :with_developer_access, rotation: rotation) }
let(:payload) { { 'fingerprint' => 'fingerprint' } } let(:payload) { { 'fingerprint' => 'fingerprint' } }
let(:resolving_payload) { { 'fingerprint' => 'fingerprint', "end_time": Time.current.iso8601 } } let(:resolving_payload) { { 'fingerprint' => 'fingerprint', "end_time": Time.current.iso8601 } }
let(:users) { [participant.user] } let(:users) { [participant.user] }
......
...@@ -23,6 +23,7 @@ RSpec.describe Projects::DestroyService do ...@@ -23,6 +23,7 @@ RSpec.describe Projects::DestroyService do
context 'when project is a mirror' do context 'when project is a mirror' do
let(:max_capacity) { Gitlab::CurrentSettings.mirror_max_capacity } let(:max_capacity) { Gitlab::CurrentSettings.mirror_max_capacity }
let_it_be(:project_mirror) { create(:project, :mirror, :repository, :import_scheduled) } let_it_be(:project_mirror) { create(:project, :mirror, :repository, :import_scheduled) }
let(:result) { described_class.new(project_mirror, project_mirror.owner, {}).execute } let(:result) { described_class.new(project_mirror, project_mirror.owner, {}).execute }
before do before do
......
...@@ -4,6 +4,7 @@ require 'spec_helper' ...@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec.describe Projects::GitlabProjectsImportService do RSpec.describe Projects::GitlabProjectsImportService do
let_it_be(:namespace) { create(:namespace) } let_it_be(:namespace) { create(:namespace) }
let(:path) { 'test-path' } let(:path) { 'test-path' }
let(:custom_template) { create(:project) } let(:custom_template) { create(:project) }
let(:overwrite) { false } let(:overwrite) { false }
......
...@@ -9,6 +9,7 @@ RSpec.describe Projects::ImportExport::ExportService do ...@@ -9,6 +9,7 @@ RSpec.describe Projects::ImportExport::ExportService do
let_it_be(:subgroup) { create(:group, :private, parent: group) } let_it_be(:subgroup) { create(:group, :private, parent: group) }
let_it_be(:project_template) { create(:project, group: subgroup) } let_it_be(:project_template) { create(:project, group: subgroup) }
let_it_be(:user) { create(:user) } let_it_be(:user) { create(:user) }
let(:shared) { project_template.import_export_shared } let(:shared) { project_template.import_export_shared }
subject { described_class.new(project_template, user).execute } subject { described_class.new(project_template, user).execute }
......
...@@ -7,6 +7,7 @@ RSpec.describe Projects::TransferService do ...@@ -7,6 +7,7 @@ RSpec.describe Projects::TransferService do
let_it_be(:user) { create(:user) } let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group, :public) } let_it_be(:group) { create(:group, :public) }
let(:project) { create(:project, :repository, :public, :legacy_storage, namespace: user.namespace) } let(:project) { create(:project, :repository, :public, :legacy_storage, namespace: user.namespace) }
subject { described_class.new(project, user) } subject { described_class.new(project, user) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment