Merge branch 'fix_version_for_external_installed' into 'master'

Set version when externally installed

See merge request gitlab-org/gitlab!58852

app/models/clusters/concerns/application_version.rb

@@ -5,11 +5,17 @@ module Clusters
     module ApplicationVersion
       extend ActiveSupport::Concern
 
+      EXTERNAL_VERSION = 'EXTERNALLY_INSTALLED'
+
       included do
         state_machine :status do
           before_transition any => [:installed, :updated] do |application|
             application.version = application.class.const_get(:VERSION, false)
           end
+
+          before_transition any => [:externally_installed] do |application|
+            application.version = EXTERNAL_VERSION
+          end
         end
       end
 

spec/support/shared_examples/models/cluster_application_version_shared_examples.rb

@@ -47,4 +47,15 @@ RSpec.shared_examples 'cluster application version specs' do |application_name|
       end
     end
   end
+
+  describe '#make_externally_installed' do
+    subject { build(application_name) }
+
+    it 'sets to a special version' do
+      subject.make_externally_installed!
+
+      expect(subject).to be_persisted
+      expect(subject.version).to eq('EXTERNALLY_INSTALLED')
+    end
+  end
 end