Merge branch '350732-registry-migration-ff-settings' into 'master'

Registry migration setting access class

See merge request gitlab-org/gitlab!79061

config/feature_flags/development/container_registry_migration_phase2_capacity_1.yml

+---
+name: container_registry_migration_phase2_capacity_1
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79061
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350543
+milestone: '14.8'
+type: development
+group: group::package
+default_enabled: false

config/feature_flags/development/container_registry_migration_phase2_capacity_10.yml

+---
+name: container_registry_migration_phase2_capacity_10
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79061
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350543
+milestone: '14.8'
+type: development
+group: group::package
+default_enabled: false

config/feature_flags/development/container_registry_migration_phase2_capacity_25.yml

+---
+name: container_registry_migration_phase2_capacity_25
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79061
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350543
+milestone: '14.8'
+type: development
+group: group::package
+default_enabled: false

config/feature_flags/development/container_registry_migration_phase2_enabled.yml

+---
+name: container_registry_migration_phase2_enabled
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79061
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350543
+milestone: '14.8'
+type: development
+group: group::package
+default_enabled: false

config/feature_flags/development/container_registry_migration_phase2_enqueue_speed_fast.yml

+---
+name: container_registry_migration_phase2_enqueue_speed_fast
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79061
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350543
+milestone: '14.8'
+type: development
+group: group::package
+default_enabled: false

config/feature_flags/development/container_registry_migration_phase2_enqueue_speed_slow.yml

+---
+name: container_registry_migration_phase2_enqueue_speed_slow
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79061
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350543
+milestone: '14.8'
+type: development
+group: group::package
+default_enabled: false

lib/container_registry/migration.rb

+# frozen_string_literal: true
+
+module ContainerRegistry
+  class Migration
+    class << self
+      delegate :container_registry_import_max_tags_count, to: ::Gitlab::CurrentSettings
+      delegate :container_registry_import_max_retries, to: ::Gitlab::CurrentSettings
+      delegate :container_registry_import_start_max_retries, to: ::Gitlab::CurrentSettings
+      delegate :container_registry_import_max_step_duration, to: ::Gitlab::CurrentSettings
+      delegate :container_registry_import_target_plan, to: ::Gitlab::CurrentSettings
+      delegate :container_registry_import_created_before, to: ::Gitlab::CurrentSettings
+
+      alias_method :max_tags_count, :container_registry_import_max_tags_count
+      alias_method :max_retries, :container_registry_import_max_retries
+      alias_method :start_max_retries, :container_registry_import_start_max_retries
+      alias_method :max_step_duration, :container_registry_import_max_step_duration
+      alias_method :target_plan_name, :container_registry_import_target_plan
+      alias_method :created_before, :container_registry_import_created_before
+    end
+
+    def self.enabled?
+      Feature.enabled?(:container_registry_migration_phase2_enabled)
+    end
+
+    def self.enqueue_waiting_time
+      return 0 if Feature.enabled?(:container_registry_migration_phase2_enqueue_speed_fast)
+      return 6.hours if Feature.enabled?(:container_registry_migration_phase2_enqueue_speed_slow)
+
+      1.hour
+    end
+
+    def self.capacity
+      return 25 if Feature.enabled?(:container_registry_migration_phase2_capacity_25)
+      return 10 if Feature.enabled?(:container_registry_migration_phase2_capacity_10)
+      return 1 if Feature.enabled?(:container_registry_migration_phase2_capacity_1)
+
+      0
+    end
+  end
+end

spec/lib/container_registry/migration_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe ContainerRegistry::Migration do
+  using RSpec::Parameterized::TableSyntax
+
+  describe '.enabled?' do
+    subject { described_class.enabled? }
+
+    it { is_expected.to eq(true) }
+
+    context 'feature flag disabled' do
+      before do
+        stub_feature_flags(container_registry_migration_phase2_enabled: false)
+      end
+
+      it { is_expected.to eq(false) }
+    end
+  end
+
+  describe '.enqueue_waiting_time' do
+    subject { described_class.enqueue_waiting_time }
+
+    where(:slow_enabled, :fast_enabled, :expected_result) do
+      false | false | 1.hour
+      true  | false | 6.hours
+      false | true  | 0
+      true  | true  | 0
+    end
+
+    with_them do
+      before do
+        stub_feature_flags(
+          container_registry_migration_phase2_enqueue_speed_slow: slow_enabled,
+          container_registry_migration_phase2_enqueue_speed_fast: fast_enabled
+        )
+      end
+
+      it { is_expected.to eq(expected_result) }
+    end
+  end
+
+  describe '.capacity' do
+    subject { described_class.capacity }
+
+    where(:ff_1_enabled, :ff_10_enabled, :ff_25_enabled, :expected_result) do
+      false | false | false | 0
+      true  | false | false | 1
+      true  | true  | false | 10
+      true  | true  | true  | 25
+      false | true  | false | 10
+      false | true  | true  | 25
+      false | false | true  | 25
+      true  | false | true  | 25
+    end
+
+    with_them do
+      before do
+        stub_feature_flags(
+          container_registry_migration_phase2_capacity_1: ff_1_enabled,
+          container_registry_migration_phase2_capacity_10: ff_10_enabled,
+          container_registry_migration_phase2_capacity_25: ff_25_enabled
+        )
+      end
+
+      it { is_expected.to eq(expected_result) }
+    end
+  end
+
+  describe '.max_tags_count' do
+    let(:value) { 1 }
+
+    before do
+      stub_application_setting(container_registry_import_max_tags_count: value)
+    end
+
+    it 'returns the matching application_setting' do
+      expect(described_class.max_tags_count).to eq(value)
+    end
+  end
+
+  describe '.max_retries' do
+    let(:value) { 1 }
+
+    before do
+      stub_application_setting(container_registry_import_max_retries: value)
+    end
+
+    it 'returns the matching application_setting' do
+      expect(described_class.max_retries).to eq(value)
+    end
+  end
+
+  describe '.start_max_retries' do
+    let(:value) { 1 }
+
+    before do
+      stub_application_setting(container_registry_import_start_max_retries: value)
+    end
+
+    it 'returns the matching application_setting' do
+      expect(described_class.start_max_retries).to eq(value)
+    end
+  end
+
+  describe '.max_step_duration' do
+    let(:value) { 5.minutes }
+
+    before do
+      stub_application_setting(container_registry_import_max_step_duration: value)
+    end
+
+    it 'returns the matching application_setting' do
+      expect(described_class.max_step_duration).to eq(value)
+    end
+  end
+
+  describe '.target_plan_name' do
+    let(:value) { 'free' }
+
+    before do
+      stub_application_setting(container_registry_import_target_plan: value)
+    end
+
+    it 'returns the matching application_setting' do
+      expect(described_class.target_plan_name).to eq(value)
+    end
+  end
+
+  describe '.created_before' do
+    let(:value) { 1.day.ago }
+
+    before do
+      stub_application_setting(container_registry_import_created_before: value)
+    end
+
+    it 'returns the matching application_setting' do
+      expect(described_class.created_before).to eq(value)
+    end
+  end
+end