Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
50ca4f84
Commit
50ca4f84
authored
Sep 28, 2020
by
Albert Salim
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Check that helm deploy exists before deleting
This prevents `release: not found` error while deleting
parent
b928a9bd
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
1 deletion
+7
-1
scripts/review_apps/review-apps.sh
scripts/review_apps/review-apps.sh
+7
-1
No files found.
scripts/review_apps/review-apps.sh
View file @
50ca4f84
...
...
@@ -48,7 +48,13 @@ function delete_release() {
return
fi
helm_delete_release
"
${
namespace
}
"
"
${
release
}
"
# Check if helm release exists before attempting to delete
# There may be situation where k8s resources exist, but helm release does not,
# for example, following a failed helm install.
# In such cases, we still want to continue to clean up k8s resources.
if
deploy_exists
"
${
namespace
}
"
"
${
release
}
"
;
then
helm_delete_release
"
${
namespace
}
"
"
${
release
}
"
fi
kubectl_cleanup_release
"
${
namespace
}
"
"
${
release
}
"
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment