Commit 522f3dfe authored by Bob Van Landuyt's avatar Bob Van Landuyt

Merge branch 'eb-remove-tracking-test-cases-feature-flag' into 'master'

Remove track_unique_test_cases_parsed feature flag

See merge request gitlab-org/gitlab!47662
parents 3f739faf e68cd16e
......@@ -39,8 +39,6 @@ module Ci
end
def track_test_cases(build, test_suite)
return if Feature.disabled?(:track_unique_test_cases_parsed, build.project)
track_usage_event(EVENT_NAME, test_case_hashes(build, test_suite))
end
......
---
title: Remove feature flag to enable tracking unique test cases parsed globally.
merge_request: 47662
author:
type: changed
---
name: track_unique_test_cases_parsed
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/41918
rollout_issue_url:
milestone: '13.5'
type: development
group: group::testing
default_enabled: false
......@@ -26,18 +26,6 @@ RSpec.describe Ci::BuildReportResultService do
expect(unique_test_cases_parsed).to eq(4)
end
context 'when feature flag for tracking is disabled' do
before do
stub_feature_flags(track_unique_test_cases_parsed: false)
end
it 'creates the report but does not track the event' do
expect(Gitlab::UsageDataCounters::HLLRedisCounter).not_to receive(:track_event)
expect(build_report_result.tests_name).to eq("test")
expect(Ci::BuildReportResult.count).to eq(1)
end
end
context 'when data has already been persisted' do
it 'raises an error and do not persist the same data twice' do
expect { 2.times { described_class.new.execute(build) } }.to raise_error(ActiveRecord::RecordNotUnique)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment