Commit 52967fb1 authored by Douglas Barbosa Alexandre's avatar Douglas Barbosa Alexandre

Merge branch 'pl-rubocop-inline-association-ca-group-stages' into 'master'

Fix cop FactoryBot/InlineAssociation offenses for CA group stages

See merge request gitlab-org/gitlab!55915
parents ffab77f3 49fbb1a4
...@@ -44,7 +44,6 @@ Graphql/Descriptions: ...@@ -44,7 +44,6 @@ Graphql/Descriptions:
# WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/267606 # WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/267606
FactoryBot/InlineAssociation: FactoryBot/InlineAssociation:
Exclude: Exclude:
- 'ee/spec/factories/analytics/cycle_analytics/group_stages.rb'
- 'ee/spec/factories/geo/event_log.rb' - 'ee/spec/factories/geo/event_log.rb'
- 'ee/spec/factories/merge_request_blocks.rb' - 'ee/spec/factories/merge_request_blocks.rb'
- 'ee/spec/factories/vulnerabilities/feedback.rb' - 'ee/spec/factories/vulnerabilities/feedback.rb'
...@@ -57,8 +56,6 @@ FactoryBot/InlineAssociation: ...@@ -57,8 +56,6 @@ FactoryBot/InlineAssociation:
- 'spec/factories/go_modules.rb' - 'spec/factories/go_modules.rb'
- 'spec/factories/group_group_links.rb' - 'spec/factories/group_group_links.rb'
- 'spec/factories/import_export_uploads.rb' - 'spec/factories/import_export_uploads.rb'
- 'spec/factories/uploads.rb'
- 'spec/factories/wiki_pages.rb'
# WIP: See https://gitlab.com/gitlab-org/gitlab/-/issues/220040 # WIP: See https://gitlab.com/gitlab-org/gitlab/-/issues/220040
Rails/SaveBang: Rails/SaveBang:
......
...@@ -7,6 +7,6 @@ FactoryBot.define do ...@@ -7,6 +7,6 @@ FactoryBot.define do
end_event_identifier { Gitlab::Analytics::CycleAnalytics::StageEvents::MergeRequestMerged.identifier } end_event_identifier { Gitlab::Analytics::CycleAnalytics::StageEvents::MergeRequestMerged.identifier }
group group
value_stream { FactoryBot.build(:cycle_analytics_group_value_stream, group: group) } value_stream { association(:cycle_analytics_group_value_stream, group: group) }
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment