Merge branch 'issue#325836-fix-empty-line-after-let-it-be-boards-module' into 'master'

Fix EmptyLineAfterFinalLetItBe Rubocop offenses for boards module

See merge request gitlab-org/gitlab!58180

.rubocop_manual_todo.yml

@@ -805,14 +805,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/controllers/invites_controller_spec.rb
     - spec/controllers/profiles/emails_controller_spec.rb
     - spec/controllers/users/terms_controller_spec.rb
-    - spec/features/boards/multiple_boards_spec.rb
-    - spec/features/boards/sidebar_assignee_spec.rb
-    - spec/features/boards/sidebar_due_date_spec.rb
-    - spec/features/boards/sidebar_labels_spec.rb
-    - spec/features/boards/sidebar_milestones_spec.rb
-    - spec/features/boards/sidebar_spec.rb
-    - spec/features/boards/sidebar_subscription_spec.rb
-    - spec/features/boards/sidebar_time_tracking_spec.rb
     - spec/features/cycle_analytics_spec.rb
     - spec/features/dashboard/datetime_on_tooltips_spec.rb
     - spec/features/dashboard/merge_requests_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-boards-module.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe Rubocop offenses for boards module
+merge_request: 58180
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/features/boards/multiple_boards_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe 'Multiple Issue Boards', :js do
   let_it_be(:planning) { create(:label, project: project, name: 'Planning') }
   let_it_be(:board) { create(:board, name: 'board1', project: project) }
   let_it_be(:board2) { create(:board, name: 'board2', project: project) }
+
   let(:parent) { project }
   let(:boards_path) { project_boards_path(project) }
 

spec/features/boards/sidebar_assignee_spec.rb

@@ -10,6 +10,7 @@ RSpec.describe 'Project issue boards sidebar assignee', :js do
   let_it_be(:development) { create(:label, project: project, name: 'Development') }
   let_it_be(:regression)  { create(:label, project: project, name: 'Regression') }
   let_it_be(:stretch)     { create(:label, project: project, name: 'Stretch') }
+
   let!(:issue1)           { create(:labeled_issue, project: project, assignees: [user], labels: [development], relative_position: 2) }
   let!(:issue2)           { create(:labeled_issue, project: project, labels: [development, stretch], relative_position: 1) }
   let(:board)             { create(:board, project: project) }

spec/features/boards/sidebar_due_date_spec.rb

@@ -10,6 +10,7 @@ RSpec.describe 'Project issue boards sidebar due date', :js do
   let_it_be(:issue)   { create(:issue, project: project, relative_position: 1) }
   let_it_be(:board)   { create(:board, project: project) }
   let_it_be(:list)    { create(:list, board: board, position: 0) }
+
   let(:card)          { find('.board:nth-child(1)').first('.board-card') }
 
   around do |example|

spec/features/boards/sidebar_labels_spec.rb

@@ -15,6 +15,7 @@ RSpec.describe 'Project issue boards sidebar labels', :js do
   let_it_be(:issue2)      { create(:labeled_issue, project: project, labels: [development, stretch], relative_position: 1) }
   let_it_be(:board)       { create(:board, project: project) }
   let_it_be(:list)        { create(:list, board: board, label: development, position: 0) }
+
   let(:card)              { find('.board:nth-child(2)').first('.board-card') }
 
   before do

spec/features/boards/sidebar_milestones_spec.rb

@@ -12,6 +12,7 @@ RSpec.describe 'Project issue boards sidebar milestones', :js do
   let_it_be(:issue2)    { create(:issue, project: project, milestone: milestone, relative_position: 2) }
   let_it_be(:board)     { create(:board, project: project) }
   let_it_be(:list)      { create(:list, board: board, position: 0) }
+
   let(:card1)           { find('.board:nth-child(1) .board-card:nth-of-type(1)') }
   let(:card2)           { find('.board:nth-child(1) .board-card:nth-of-type(2)') }