Merge branch 'ss/rm-enable-label-perma-links' into 'master'

Rm enableLabelPermalinks from components

See merge request gitlab-org/gitlab!80239

app/assets/javascripts/vue_shared/issuable/list/components/issuable_item.vue

@@ -31,10 +31,6 @@ export default {
       type: Object,
       required: true,
     },
-    enableLabelPermalinks: {
-      type: Boolean,
-      required: true,
-    },
     labelFilterParam: {
       type: String,
       required: false,
@@ -142,11 +138,8 @@ export default {
       return label.title || label.name;
     },
     labelTarget(label) {
-      if (this.enableLabelPermalinks) {
-        const value = encodeURIComponent(this.labelTitle(label));
-        return `?${this.labelFilterParam}[]=${value}`;
-      }
-      return '#';
+      const value = encodeURIComponent(this.labelTitle(label));
+      return `?${this.labelFilterParam}[]=${value}`;
     },
     /**
      * This is needed as an independent method since

app/assets/javascripts/vue_shared/issuable/list/components/issuable_list_root.vue

@@ -133,11 +133,6 @@ export default {
       required: false,
       default: 2,
     },
-    enableLabelPermalinks: {
-      type: Boolean,
-      required: false,
-      default: true,
-    },
     labelFilterParam: {
       type: String,
       required: false,
@@ -321,7 +316,6 @@ export default {
           :data-qa-issuable-title="issuable.title"
           :issuable-symbol="issuableSymbol"
           :issuable="issuable"
-          :enable-label-permalinks="enableLabelPermalinks"
           :label-filter-param="labelFilterParam"
           :show-checkbox="showBulkEditSidebar"
           :checked="issuableChecked(issuable)"

ee/spec/frontend/external_issues_list/components/__snapshots__/external_issues_list_root_spec.js.snap

@@ -13,7 +13,6 @@ Object {
   "currentPage": 1,
   "currentTab": "opened",
   "defaultPageSize": 2,
-  "enableLabelPermalinks": true,
   "error": "",
   "hasNextPage": false,
   "hasPreviousPage": false,

spec/frontend/vue_shared/issuable/list/components/issuable_item_spec.js

@@ -10,7 +10,6 @@ import { mockIssuable, mockRegularLabel, mockScopedLabel } from '../mock_data';
 const createComponent = ({
   issuableSymbol = '#',
   issuable = mockIssuable,
-  enableLabelPermalinks = true,
   showCheckbox = true,
   slots = {},
 } = {}) =>
@@ -18,7 +17,6 @@ const createComponent = ({
     propsData: {
       issuableSymbol,
       issuable,
-      enableLabelPermalinks,
       showDiscussions: true,
       showCheckbox,
     },
@@ -212,23 +210,13 @@ describe('IssuableItem', () => {
     });
 
     describe('labelTarget', () => {
-      it('returns target string for a provided label param when `enableLabelPermalinks` is true', () => {
+      it('returns target string for a provided label param', () => {
         wrapper = createComponent();
 
         expect(wrapper.vm.labelTarget(mockRegularLabel)).toBe(
           '?label_name[]=Documentation%20Update',
         );
       });
-
-      it('returns string "#" for a provided label param when `enableLabelPermalinks` is false', async () => {
-        wrapper = createComponent({
-          enableLabelPermalinks: false,
-        });
-
-        await nextTick();
-
-        expect(wrapper.vm.labelTarget(mockRegularLabel)).toBe('#');
-      });
     });
   });