Merge branch 'fix-ee-rubocop-dot-position-cop' into 'master'

Fix remaining DotPosition cops 👮

Closes #2710

See merge request !2211

app/finders/events_finder.rb

@@ -33,8 +33,8 @@ class EventsFinder
   private
 
   def by_current_user_access(events)
-    events.merge(ProjectsFinder.new(current_user: current_user).execute).
-      joins(:project)
+    events.merge(ProjectsFinder.new(current_user: current_user).execute)
+      .joins(:project)
   end
 
   def by_action(events)

app/models/project.rb

@@ -275,10 +275,10 @@ class Project < ActiveRecord::Base
   # logged in user.
   def self.public_or_visible_to_user(user = nil)
     if user
-      authorized = user.
-        project_authorizations.
-        select(1).
-        where('project_authorizations.project_id = projects.id')
+      authorized = user
+        .project_authorizations
+        .select(1)
+        .where('project_authorizations.project_id = projects.id')
 
       levels = Gitlab::VisibilityLevel.levels_for_user(user)
 
@@ -303,11 +303,11 @@ class Project < ActiveRecord::Base
     elsif user
       column = ProjectFeature.quoted_access_level_column(feature)
 
-      authorized = user.project_authorizations.select(1).
-        where('project_authorizations.project_id = projects.id')
+      authorized = user.project_authorizations.select(1)
+        .where('project_authorizations.project_id = projects.id')
 
-      with_project_feature.
-        where("#{column} IN (?) OR (#{column} = ? AND EXISTS (?))",
+      with_project_feature
+        .where("#{column} IN (?) OR (#{column} = ? AND EXISTS (?))",
               visible,
               ProjectFeature::PRIVATE,
               authorized)

spec/controllers/projects_controller_spec.rb

@@ -176,8 +176,8 @@ describe ProjectsController do
 
       context 'project repo over limit' do
         before do
-          allow_any_instance_of(EE::Project).
-            to receive(:above_size_limit?).and_return(true)
+          allow_any_instance_of(EE::Project)
+            .to receive(:above_size_limit?).and_return(true)
 
           project.team << [user, :master]
         end

spec/lib/gitlab/ee/visibility_level_spec.rb

@@ -5,10 +5,10 @@ describe Gitlab::VisibilityLevel, lib: true do  # rubocop:disable RSpec/FilePath
     it 'returns all levels for an auditor' do
       user = build(:user, :auditor)
 
-      expect(described_class.levels_for_user(user)).
-        to eq([Gitlab::VisibilityLevel::PRIVATE,
-               Gitlab::VisibilityLevel::INTERNAL,
-               Gitlab::VisibilityLevel::PUBLIC])
+      expect(described_class.levels_for_user(user))
+        .to eq([Gitlab::VisibilityLevel::PRIVATE,
+                Gitlab::VisibilityLevel::INTERNAL,
+                Gitlab::VisibilityLevel::PUBLIC])
     end
   end
 end

spec/lib/gitlab/visibility_level_spec.rb

@@ -23,30 +23,30 @@ describe Gitlab::VisibilityLevel, lib: true do
     it 'returns all levels for an admin' do
       user = build(:user, :admin)
 
-      expect(described_class.levels_for_user(user)).
-        to eq([Gitlab::VisibilityLevel::PRIVATE,
-               Gitlab::VisibilityLevel::INTERNAL,
-               Gitlab::VisibilityLevel::PUBLIC])
+      expect(described_class.levels_for_user(user))
+        .to eq([Gitlab::VisibilityLevel::PRIVATE,
+                Gitlab::VisibilityLevel::INTERNAL,
+                Gitlab::VisibilityLevel::PUBLIC])
     end
 
     it 'returns INTERNAL and PUBLIC for internal users' do
       user = build(:user)
 
-      expect(described_class.levels_for_user(user)).
-        to eq([Gitlab::VisibilityLevel::INTERNAL,
-               Gitlab::VisibilityLevel::PUBLIC])
+      expect(described_class.levels_for_user(user))
+        .to eq([Gitlab::VisibilityLevel::INTERNAL,
+                Gitlab::VisibilityLevel::PUBLIC])
     end
 
     it 'returns PUBLIC for external users' do
       user = build(:user, :external)
 
-      expect(described_class.levels_for_user(user)).
-        to eq([Gitlab::VisibilityLevel::PUBLIC])
+      expect(described_class.levels_for_user(user))
+        .to eq([Gitlab::VisibilityLevel::PUBLIC])
     end
 
     it 'returns PUBLIC when no user is given' do
-      expect(described_class.levels_for_user).
-        to eq([Gitlab::VisibilityLevel::PUBLIC])
+      expect(described_class.levels_for_user)
+        .to eq([Gitlab::VisibilityLevel::PUBLIC])
     end
   end
 end

spec/requests/git_http_spec.rb

@@ -768,8 +768,8 @@ describe 'Git HTTP requests', lib: true do
           end
 
           it 'responds with status 403 Forbidden' do
-            allow_any_instance_of(EE::Project).
-              to receive(:above_size_limit?).and_return(true)
+            allow_any_instance_of(EE::Project)
+              .to receive(:above_size_limit?).and_return(true)
 
             upload(path, env) do |response|
               expect(response).to have_http_status(:forbidden)