Merge branch '276901-remove-ci_lint_creates_pipeline_with_dry_run' into 'master'

Remove ci_lint_creates_pipeline_with_dry_run flag

See merge request gitlab-org/gitlab!47426

config/feature_flags/development/ci_lint_creates_pipeline_with_dry_run.yml

----
-name: ci_lint_creates_pipeline_with_dry_run
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37828
-rollout_issue_url: 
-milestone: '13.3'
-type: development
-group: group::continuous integration
-default_enabled: true

lib/gitlab/ci/features.rb

@@ -38,10 +38,6 @@ module Gitlab
         ::Feature.enabled?(:ci_disallow_to_create_merge_request_pipelines_in_target_project, target_project)
       end
 
-      def self.lint_creates_pipeline_with_dry_run?(project)
-        ::Feature.enabled?(:ci_lint_creates_pipeline_with_dry_run, project, default_enabled: true)
-      end
-
       def self.project_transactionless_destroy?(project)
         Feature.enabled?(:project_transactionless_destroy, project, default_enabled: false)
       end

lib/gitlab/ci/lint.rb

@@ -24,7 +24,7 @@ module Gitlab
       end
 
       def validate(content, dry_run: false)
-        if dry_run && Gitlab::Ci::Features.lint_creates_pipeline_with_dry_run?(@project)
+        if dry_run
           simulate_pipeline_creation(content)
         else
           static_validation(content)

spec/controllers/projects/ci/lints_controller_spec.rb

@@ -123,20 +123,6 @@ RSpec.describe Projects::Ci::LintsController do
 
           subject
         end
-
-        context 'when dry_run feature flag is disabled' do
-          before do
-            stub_feature_flags(ci_lint_creates_pipeline_with_dry_run: false)
-          end
-
-          it_behaves_like 'returns a successful validation'
-
-          it 'runs validations through YamlProcessor' do
-            expect(Gitlab::Ci::YamlProcessor).to receive(:new).and_call_original
-
-            subject
-          end
-        end
       end
     end