Comments in issue [#1](https://gitlab.com/gitlab-org/gitlab/issues/30528) indicate that these should both be set to at least a number of minutes for all Omnibus installations (so they don't hang indefinitely). However, 15s for statement_timeout is very short, and will only be effective if the underlying infrastructure is very performant.
Comments in issue [#1](https://gitlab.com/gitlab-org/gitlab/issues/30528) indicate that these should both be set to at least a number of minutes for all Omnibus installations (so they don't hang indefinitely). However, 15s for statement_timeout is very short, and will only be effective if the underlying infrastructure is very performant.
@@ -58,7 +58,7 @@ The author then adds a comment to this piece of code and adds a link to the issu
...
@@ -58,7 +58,7 @@ The author then adds a comment to this piece of code and adds a link to the issu
- Track necessary events. See the [telemetry guide](../../telemetry/index.md) for details.
- Track necessary events. See the [telemetry guide](../../telemetry/index.md) for details.
- After the merge request is merged, use [`chatops`](../../ci/chatops/README.md) to enable the feature flag and start the experiment. For visibility, please run the command in the `#s_growth` channel:
- After the merge request is merged, use [`chatops`](../../ci/chatops/README.md) to enable the feature flag and start the experiment. For visibility, please run the command in the `#s_growth` channel:
```
```shell
/chatops run feature set--project=gitlab-org/gitlab experimental_sign_up_flow true
/chatops run feature set--project=gitlab-org/gitlab experimental_sign_up_flow true
@@ -10,9 +10,9 @@ Copy the content over to your issue or merge request and if something doesn't ap
...
@@ -10,9 +10,9 @@ Copy the content over to your issue or merge request and if something doesn't ap
This checklist is intended to help us during development of bigger features/refactorings, it's not a "use it always and every point always matches" list.
This checklist is intended to help us during development of bigger features/refactorings, it's not a "use it always and every point always matches" list.
Please use your best judgement when to use it and please contribute new points through merge requests if something comes to your mind.
Please use your best judgment when to use it and please contribute new points through merge requests if something comes to your mind.
@@ -149,7 +149,7 @@ Using local Apollo Cache is handy when we have a need to mock some GraphQL API r
...
@@ -149,7 +149,7 @@ Using local Apollo Cache is handy when we have a need to mock some GraphQL API r
For example, we have a [fragment](#fragments) on `DesignVersion` used in our queries:
For example, we have a [fragment](#fragments) on `DesignVersion` used in our queries:
```
```javascript
fragmentVersionListItemonDesignVersion{
fragmentVersionListItemonDesignVersion{
id
id
sha
sha
...
@@ -158,7 +158,7 @@ fragment VersionListItem on DesignVersion {
...
@@ -158,7 +158,7 @@ fragment VersionListItem on DesignVersion {
We need to fetch also version author and the 'created at' property to display them in the versions dropdown but these changes are still not implemented in our API. We can change the existing fragment to get a mocked response for these new fields:
We need to fetch also version author and the 'created at' property to display them in the versions dropdown but these changes are still not implemented in our API. We can change the existing fragment to get a mocked response for these new fields:
@@ -64,36 +64,36 @@ The easiest way to include prettier in your workflow is by setting up your prefe
...
@@ -64,36 +64,36 @@ The easiest way to include prettier in your workflow is by setting up your prefe
Please take care that you only let Prettier format the same file types as the global Yarn script does (.js, .vue, and .scss). In VSCode by example you can easily exclude file formats in your settings file:
Please take care that you only let Prettier format the same file types as the global Yarn script does (.js, .vue, and .scss). In VSCode by example you can easily exclude file formats in your settings file:
```
```json
"prettier.disableLanguages":[
"prettier.disableLanguages":[
"json",
"json",
"markdown"
"markdown"
],
]
```
```
### Yarn Script
### Yarn Script
The following yarn scripts are available to do global formatting:
The following yarn scripts are available to do global formatting:
```
```shell
yarn prettier-staged-save
yarn prettier-staged-save
```
```
Updates all currently staged files (based on `git diff`) with Prettier and saves the needed changes.
Updates all currently staged files (based on `git diff`) with Prettier and saves the needed changes.
```
```shell
yarn prettier-staged
yarn prettier-staged
```
```
Checks all currently staged files (based on `git diff`) with Prettier and log which files would need manual updating to the console.
Checks all currently staged files (based on `git diff`) with Prettier and log which files would need manual updating to the console.
```
```shell
yarn prettier-all
yarn prettier-all
```
```
Checks all files with Prettier and logs which files need manual updating to the console.
Checks all files with Prettier and logs which files need manual updating to the console.
```
```shell
yarn prettier-all-save
yarn prettier-all-save
```
```
...
@@ -103,13 +103,13 @@ The source of these Yarn scripts can be found in `/scripts/frontend/prettier.js`
...
@@ -103,13 +103,13 @@ The source of these Yarn scripts can be found in `/scripts/frontend/prettier.js`