Merge branch 'qa-standardize-spec-project-fabrication' into 'master'

Standardize Manage Release and Package E2E project fabrication

See merge request gitlab-org/gitlab!24619

qa/qa/specs/features/browser_ui/1_manage/project/add_project_member_spec.rb

@@ -8,10 +8,9 @@ module QA
 
         user = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1)
 
-        project = Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'add-member-project'
-        end
-        project.visit!
+        Resource::Project.fabricate_via_api! do |project|
+          project.name = 'add-member-project'
+        end.visit!
 
         Page::Project::Menu.perform(&:go_to_members_settings)
         Page::Project::Settings::Members.perform do |members|

qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb

@@ -10,8 +10,8 @@ module QA
 
         @runner_name = "qa-runner-#{Time.now.to_i}"
 
-        @project = Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'deploy-key-clone-project'
+        @project = Resource::Project.fabricate_via_api! do |project|
+          project.name = 'deploy-key-clone-project'
         end
 
         @repository_location = @project.repository_ssh_location

qa/qa/specs/features/ee/browser_ui/5_package/npm_registry_spec.rb

@@ -15,8 +15,8 @@ module QA
         Resource::PersonalAccessToken.fabricate!.access_token
       end
       let(:project) do
-        Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'npm-registry-project'
+        Resource::Project.fabricate_via_api! do |project|
+          project.name = 'npm-registry-project'
         end
       end