Commit 5a44db12 authored by Valerie Burton's avatar Valerie Burton Committed by Dan Davison

Remove requires_admin Tag From E2E Specs That Previously Used...

Remove requires_admin Tag From E2E Specs That Previously Used invite_members_group_modal Feature Flag
parent 9f222d4c
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
RSpec.describe 'Manage', :requires_admin, :reliable do RSpec.describe 'Manage', :reliable do
describe 'Add project member' do describe 'Add project member' do
it 'user adds project member', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347887' do it 'user adds project member', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347887' do
Flow::Login.sign_in Flow::Login.sign_in
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
module QA module QA
# Tagging with issue for a transient invite group modal search bug, but does not require quarantine at this time # Tagging with issue for a transient invite group modal search bug, but does not require quarantine at this time
RSpec.describe 'Manage', :requires_admin, :transient, issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/349379' do RSpec.describe 'Manage', :transient, issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/349379' do
describe 'Invite group' do describe 'Invite group' do
shared_examples 'invites group to project' do shared_examples 'invites group to project' do
it 'verifies group is added and members can access project with correct access level' do it 'verifies group is added and members can access project with correct access level' do
...@@ -16,6 +16,8 @@ module QA ...@@ -16,6 +16,8 @@ module QA
Flow::Login.sign_in(as: @user) Flow::Login.sign_in(as: @user)
Page::Dashboard::Projects.perform do |projects| Page::Dashboard::Projects.perform do |projects|
projects.filter_by_name(project.name)
expect(projects).to have_project_with_access_role(project.name, 'Developer') expect(projects).to have_project_with_access_role(project.name, 'Developer')
end end
......
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
RSpec.describe 'Plan', :orchestrated, :smtp, :requires_admin do RSpec.describe 'Plan', :orchestrated, :smtp do
describe 'Email Notification' do describe 'Email Notification' do
include Support::API include Support::API
......
...@@ -23,7 +23,7 @@ module QA ...@@ -23,7 +23,7 @@ module QA
end end
end end
describe 'Group', :requires_admin do describe 'Group' do
let(:group) do let(:group) do
Resource::Group.fabricate_via_api! do |resource| Resource::Group.fabricate_via_api! do |resource|
resource.path = "test-group-#{SecureRandom.hex(8)}" resource.path = "test-group-#{SecureRandom.hex(8)}"
...@@ -82,7 +82,7 @@ module QA ...@@ -82,7 +82,7 @@ module QA
it_behaves_like 'audit event', ['Changed name'] it_behaves_like 'audit event', ['Changed name']
end end
context 'Add user, change access level, remove user', :requires_admin, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347911' do context 'Add user, change access level, remove user', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347911' do
before do before do
sign_in sign_in
group.visit! group.visit!
...@@ -97,7 +97,7 @@ module QA ...@@ -97,7 +97,7 @@ module QA
it_behaves_like 'audit event', ['Added user access as Guest', 'Changed access level', 'Removed user access'] it_behaves_like 'audit event', ['Added user access as Guest', 'Changed access level', 'Removed user access']
end end
context 'Add and remove project access', :requires_admin, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347912' do context 'Add and remove project access', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347912' do
before do before do
sign_in sign_in
project.visit! project.visit!
......
...@@ -3,8 +3,6 @@ ...@@ -3,8 +3,6 @@
module QA module QA
RSpec.describe 'Manage' do RSpec.describe 'Manage' do
describe 'Group with members' do describe 'Group with members' do
let(:admin_api_client) { Runtime::API::Client.as_admin }
let(:source_group_with_members) do let(:source_group_with_members) do
Resource::Group.fabricate_via_api! do |group| Resource::Group.fabricate_via_api! do |group|
group.path = "source-group-with-members_#{SecureRandom.hex(8)}" group.path = "source-group-with-members_#{SecureRandom.hex(8)}"
...@@ -24,21 +22,13 @@ module QA ...@@ -24,21 +22,13 @@ module QA
end end
end end
let(:maintainer_user) do let(:maintainer_user) { Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1) }
Resource::User.fabricate_via_api! do |resource|
resource.api_client = admin_api_client
end
end
before do before do
source_group_with_members.add_member(maintainer_user, Resource::Members::AccessLevel::MAINTAINER) source_group_with_members.add_member(maintainer_user, Resource::Members::AccessLevel::MAINTAINER)
end end
after do it 'can be shared with another group with correct access level', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347935' do
maintainer_user.remove_via_api!
end
it 'can be shared with another group with correct access level', :requires_admin, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347935' do
Flow::Login.sign_in Flow::Login.sign_in
target_group_with_project.visit! target_group_with_project.visit!
...@@ -54,6 +44,8 @@ module QA ...@@ -54,6 +44,8 @@ module QA
Flow::Login.sign_in(as: maintainer_user) Flow::Login.sign_in(as: maintainer_user)
Page::Dashboard::Projects.perform do |projects| Page::Dashboard::Projects.perform do |projects|
projects.filter_by_name(project.name)
expect(projects).to have_project_with_access_role(project.name, "Guest") expect(projects).to have_project_with_access_role(project.name, "Guest")
end end
end end
......
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
# TODO: Remove :requires_admin when the `Runtime::Feature.enable` method call is removed
RSpec.describe 'Create', :requires_admin do RSpec.describe 'Create', :requires_admin do
describe 'Codeowners' do describe 'Codeowners' do
let(:files) do let(:files) do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment