Merge branch 'debian_tidy_specs' into 'master'

Tidy up Debian repository specs

See merge request gitlab-org/gitlab!60568

spec/requests/api/debian_group_packages_spec.rb

@@ -5,35 +5,35 @@ RSpec.describe API::DebianGroupPackages do
   include HttpBasicAuthHelpers
   include WorkhorseHelpers
 
-  include_context 'Debian repository shared context', :group do
+  include_context 'Debian repository shared context', :group, false do
     describe 'GET groups/:id/-/packages/debian/dists/*distribution/Release.gpg' do
-      let(:url) { "/groups/#{group.id}/-/packages/debian/dists/#{distribution}/Release.gpg" }
+      let(:url) { "/groups/#{container.id}/-/packages/debian/dists/#{distribution}/Release.gpg" }
 
-      it_behaves_like 'Debian group repository GET endpoint', :not_found, nil
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :not_found
     end
 
     describe 'GET groups/:id/-/packages/debian/dists/*distribution/Release' do
-      let(:url) { "/groups/#{group.id}/-/packages/debian/dists/#{distribution}/Release" }
+      let(:url) { "/groups/#{container.id}/-/packages/debian/dists/#{distribution}/Release" }
 
-      it_behaves_like 'Debian group repository GET endpoint', :success, 'TODO Release'
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :success, 'TODO Release'
     end
 
     describe 'GET groups/:id/-/packages/debian/dists/*distribution/InRelease' do
-      let(:url) { "/groups/#{group.id}/-/packages/debian/dists/#{distribution}/InRelease" }
+      let(:url) { "/groups/#{container.id}/-/packages/debian/dists/#{distribution}/InRelease" }
 
-      it_behaves_like 'Debian group repository GET endpoint', :not_found, nil
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :not_found
     end
 
     describe 'GET groups/:id/-/packages/debian/dists/*distribution/:component/binary-:architecture/Packages' do
-      let(:url) { "/groups/#{group.id}/-/packages/debian/dists/#{distribution}/#{component}/binary-#{architecture}/Packages" }
+      let(:url) { "/groups/#{container.id}/-/packages/debian/dists/#{distribution}/#{component}/binary-#{architecture}/Packages" }
 
-      it_behaves_like 'Debian group repository GET endpoint', :success, 'TODO Packages'
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :success, 'TODO Packages'
     end
 
     describe 'GET groups/:id/-/packages/debian/pool/:component/:letter/:source_package/:file_name' do
-      let(:url) { "/groups/#{group.id}/-/packages/debian/pool/#{component}/#{letter}/#{source_package}/#{package_name}_#{package_version}_#{architecture}.deb" }
+      let(:url) { "/groups/#{container.id}/-/packages/debian/pool/#{component}/#{letter}/#{source_package}/#{package_name}_#{package_version}_#{architecture}.deb" }
 
-      it_behaves_like 'Debian group repository GET endpoint', :success, 'TODO File'
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :success, 'TODO File'
     end
   end
 end

spec/requests/api/debian_project_packages_spec.rb

@@ -5,49 +5,49 @@ RSpec.describe API::DebianProjectPackages do
   include HttpBasicAuthHelpers
   include WorkhorseHelpers
 
-  include_context 'Debian repository shared context', :project do
+  include_context 'Debian repository shared context', :project, true do
     describe 'GET projects/:id/packages/debian/dists/*distribution/Release.gpg' do
-      let(:url) { "/projects/#{project.id}/packages/debian/dists/#{distribution}/Release.gpg" }
+      let(:url) { "/projects/#{container.id}/packages/debian/dists/#{distribution}/Release.gpg" }
 
-      it_behaves_like 'Debian project repository GET endpoint', :not_found, nil
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :not_found
     end
 
     describe 'GET projects/:id/packages/debian/dists/*distribution/Release' do
-      let(:url) { "/projects/#{project.id}/packages/debian/dists/#{distribution}/Release" }
+      let(:url) { "/projects/#{container.id}/packages/debian/dists/#{distribution}/Release" }
 
-      it_behaves_like 'Debian project repository GET endpoint', :success, 'TODO Release'
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :success, 'TODO Release'
     end
 
     describe 'GET projects/:id/packages/debian/dists/*distribution/InRelease' do
-      let(:url) { "/projects/#{project.id}/packages/debian/dists/#{distribution}/InRelease" }
+      let(:url) { "/projects/#{container.id}/packages/debian/dists/#{distribution}/InRelease" }
 
-      it_behaves_like 'Debian project repository GET endpoint', :not_found, nil
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :not_found
     end
 
     describe 'GET projects/:id/packages/debian/dists/*distribution/:component/binary-:architecture/Packages' do
-      let(:url) { "/projects/#{project.id}/packages/debian/dists/#{distribution}/#{component}/binary-#{architecture}/Packages" }
+      let(:url) { "/projects/#{container.id}/packages/debian/dists/#{distribution}/#{component}/binary-#{architecture}/Packages" }
 
-      it_behaves_like 'Debian project repository GET endpoint', :success, 'TODO Packages'
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :success, 'TODO Packages'
     end
 
     describe 'GET projects/:id/packages/debian/pool/:component/:letter/:source_package/:file_name' do
-      let(:url) { "/projects/#{project.id}/packages/debian/pool/#{component}/#{letter}/#{source_package}/#{package_name}_#{package_version}_#{architecture}.deb" }
+      let(:url) { "/projects/#{container.id}/packages/debian/pool/#{component}/#{letter}/#{source_package}/#{package_name}_#{package_version}_#{architecture}.deb" }
 
-      it_behaves_like 'Debian project repository GET endpoint', :success, 'TODO File'
+      it_behaves_like 'Debian repository read endpoint', 'GET request', :success, 'TODO File'
     end
 
     describe 'PUT projects/:id/packages/debian/:file_name' do
       let(:method) { :put }
-      let(:url) { "/projects/#{project.id}/packages/debian/#{file_name}" }
+      let(:url) { "/projects/#{container.id}/packages/debian/#{file_name}" }
 
-      it_behaves_like 'Debian project repository PUT endpoint', :created, nil
+      it_behaves_like 'Debian repository write endpoint', 'upload request', :created
     end
 
     describe 'PUT projects/:id/packages/debian/:file_name/authorize' do
       let(:method) { :put }
-      let(:url) { "/projects/#{project.id}/packages/debian/#{file_name}/authorize" }
+      let(:url) { "/projects/#{container.id}/packages/debian/#{file_name}/authorize" }
 
-      it_behaves_like 'Debian project repository PUT endpoint', :created, nil, is_authorize: true
+      it_behaves_like 'Debian repository write endpoint', 'upload authorize request', :created
     end
   end
 end