Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5c636b15
Commit
5c636b15
authored
May 16, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
8975fbdb
3d2edaac
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
57 additions
and
1 deletion
+57
-1
doc/development/documentation/index.md
doc/development/documentation/index.md
+56
-0
doc/user/permissions.md
doc/user/permissions.md
+1
-1
No files found.
doc/development/documentation/index.md
View file @
5c636b15
...
...
@@ -52,6 +52,58 @@ Adhere to the [Documentation Style Guide](styleguide.md). If a style standard is
See the
[
Structure
](
styleguide.md#structure
)
section of the
[
Documentation Style Guide
](
styleguide.md
)
.
## Single codebase
We currently maintain two sets of docs: one in the
[
gitlab-ce
](
https://gitlab.com/gitlab-org/gitlab-ce/tree/master/doc
)
repo and
one in
[
gitlab-ee
](
https://gitlab.com/gitlab-org/gitlab-ee/tree/master/doc
)
.
They are similar, and most pages are identical, but they are different repositories.
With the single codebase effort, we want to make those two sets identical, so when the
time comes to have only one codebase, we'll be ready.
Here are some links to get you up to speed with the current effort:
-
[
CE/EE codebases blueprint
](
https://about.gitlab.com/handbook/engineering/infrastructure/blueprint/ce-ee-codebases/
)
-
[
CE/EE codebases merge design
](
https://about.gitlab.com/handbook/engineering/infrastructure/design/merge-ce-ee-codebases/
)
-
[
Single docs codebase epic
](
https://gitlab.com/groups/gitlab-org/-/epics/199
)
-
[
Issue board of related issues
](
https://gitlab.com/groups/gitlab-org/-/boards/981090?&label_name[]=Documentation&label_name[]=single%20codebase
)
-
[
Related merge requests
](
https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=all&utf8=%E2%9C%93&state=all&label_name[]=Documentation&label_name[]=single%20codebase
)
-
[
Visualize the existing diffs
](
https://leipert-projects.gitlab.io/is-gitlab-pretty-yet/diff/?search=%5Edoc
)
### CE first
After a given documentation path is aligned across CE and EE, all merge requests
affecting that path must be submitted to CE, regardless of the content it has.
This means that for EE-only features which are being added only to the EE codebase,
you have to submit a separate merge request in CE that contains the docs.
This might seem like a duplicate effort, but it's for the short term.
A list of the already aligned docs can be found in
[
the epic description
](
https://gitlab.com/groups/gitlab-org/-/epics/199#ee-specific-lines-check
)
.
Since the docs will be combined, it's crucial to add the relevant
[
product badges
](
styleguide.md#product-badges
)
for all EE documentation, so that
we can discern which features belong to which tier.
### EE specific lines check
There's a special test in place
(
[
`ee_specific_check.rb`
](
https://gitlab.com/gitlab-org/gitlab-ee/blob/master/scripts/ee_specific_check/ee_specific_check.rb
)
),
which, among others, checks and prevents creating/editing new files and directories
in EE under
`doc/`
.
We have a long list of documentation paths that are either whitelisted or not.
Paths in the whitelist (not commented out) will not be subject to the test,
which means you are allowed to create/change docs content in EE for the time
being. The goal is to not have any doc whitelisted.
At the time of this writing, the only items left to be aligned are:
-
`doc/api/*`
(
[
issue
](
https://gitlab.com/gitlab-org/gitlab-ce/issues/60045
)
/
[
merge request
](
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27491
)
)
-
`doc/README.md`
Eventually, once all docs are aligned, we'll remove any doc reference from that
script, so it catches everything.
## Changing document location
Changing a document's location requires specific steps to be followed to ensure that
...
...
@@ -438,6 +490,10 @@ Currently, the following tests are in place:
As CE is merged into EE once a day, it's important to avoid merge conflicts.
Submitting an EE-equivalent merge request cherry-picking all commits from CE to EE is
essential to avoid them.
1. [`ee-files-location-check`/`ee-specific-lines-check`](#ee-specific-lines-check) (runs on EE only):
This test ensures that no new files/directories are created/changed in EE.
All docs should be submitted in CE instead, regardless the tier they are on.
This is for the [single codebase](#single-codebase) effort.
1. In a full pipeline, tests for [`/help`](#gitlab-help-tests).
### Linting
...
...
doc/user/permissions.md
View file @
5c636b15
...
...
@@ -11,7 +11,7 @@ project itself, the highest permission level is used.
On public and internal projects the Guest role is not enforced. All users will
be able to create issues, leave comments, and clone or download the project code.
When a member leaves
the team
all the assigned
[
Issues
](
project/issues/index.md
)
and
[
Merge Requests
](
project/merge_requests/index.md
)
When a member leaves
a team's project,
all the assigned
[
Issues
](
project/issues/index.md
)
and
[
Merge Requests
](
project/merge_requests/index.md
)
will be unassigned automatically.
GitLab
[
administrators
](
../administration/index.md
)
receive all permissions.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment