Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5d1b64dc
Commit
5d1b64dc
authored
Mar 11, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
2857f9b5
e8e25a0f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
60 additions
and
1 deletion
+60
-1
Dangerfile
Dangerfile
+1
-0
danger/roulette/Dangerfile
danger/roulette/Dangerfile
+3
-1
danger/single_codebase/Dangerfile
danger/single_codebase/Dangerfile
+56
-0
No files found.
Dangerfile
View file @
5d1b64dc
...
...
@@ -12,3 +12,4 @@ danger.import_dangerfile(path: 'danger/duplicate_yarn_dependencies')
danger
.
import_dangerfile
(
path:
'danger/prettier'
)
danger
.
import_dangerfile
(
path:
'danger/eslint'
)
danger
.
import_dangerfile
(
path:
'danger/roulette'
)
danger
.
import_dangerfile
(
path:
'danger/single_codebase'
)
danger/roulette/Dangerfile
View file @
5d1b64dc
...
...
@@ -58,7 +58,9 @@ changes = helper.changes_by_category
changes
.
delete
(
:none
)
categories
=
changes
.
keys
-
[
:unknown
]
unless
changes
.
empty?
# Single codebase MRs are reviewed using a slightly different process, so we
# disable the review roulette for such MRs.
if
changes
.
any?
&&
!
gitlab
.
mr_labels
.
include?
(
'single codebase'
)
team
=
begin
helper
.
project_team
...
...
danger/single_codebase/Dangerfile
0 → 100644
View file @
5d1b64dc
def
mention_single_codebase_approvers
frontend_maintainers
=
%w(@filipa @iamphill)
backend_maintainers
=
%w(@rspeicher @rymai @yorickpeterse @godfat)
rows
=
[]
users
=
[]
if
gitlab
.
mr_labels
.
include?
(
'frontend'
)
frontend_maintainer
=
frontend_maintainers
.
sample
rows
<<
"| ~frontend | `
#{
frontend_maintainer
}
`"
users
<<
frontend_maintainer
end
if
gitlab
.
mr_labels
.
include?
(
'backend'
)
backend_maintainer
=
backend_maintainers
.
sample
rows
<<
"| ~backend | `
#{
backend_maintainer
}
`"
users
<<
backend_maintainer
end
if
rows
.
empty?
backup_maintainer
=
backend_maintainers
.
sample
rows
<<
"| ~frontend / ~backend | `
#{
backup_maintainer
}
`"
users
<<
backup_maintainer
end
markdown
(
<<~
MARKDOWN
.
strip
)
## Single codebase changes
This merge request contains changes related to the work of moving towards a
[single codebase](https://gitlab.com/groups/gitlab-org/-/epics/802) for
Community Edition and Enterprise Edition. These changes will need to be
reviewed and approved by the following engineers:
| Category | Reviewer
|----------|---------
#{
rows
.
join
(
"
\n
"
)
}
To make sure this happens, please follow these steps:
1. Add all of the mentioned users to the list of merge request approvals.
2. Assign the merge request to the first person in the above list.
If you are a reviewer, please follow these steps:
1. Review the merge request. If it is good to go, approve it.
2. Once approved, assign to the next person in the above list. If you are
the last person in the list, merge the merge request.
MARKDOWN
end
if
gitlab
.
mr_labels
.
include?
(
'single codebase'
)
mention_single_codebase_approvers
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment