Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5d419653
Commit
5d419653
authored
Jun 17, 2020
by
Andy Soiron
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add RSpec. to top level class describe blocks
THis is to enforce RSpec zero monkey patching mode
parent
4d460c88
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
8 deletions
+8
-8
doc/development/geo/framework.md
doc/development/geo/framework.md
+5
-5
doc/development/gotchas.md
doc/development/gotchas.md
+2
-2
doc/development/testing_guide/testing_migrations_guide.md
doc/development/testing_guide/testing_migrations_guide.md
+1
-1
No files found.
doc/development/geo/framework.md
View file @
5d419653
...
@@ -215,7 +215,7 @@ For example, to add support for files referenced by a `Widget` model with a
...
@@ -215,7 +215,7 @@ For example, to add support for files referenced by a `Widget` model with a
require
'spec_helper'
require
'spec_helper'
describe
Geo
::
WidgetReplicator
do
RSpec
.
describe
Geo
::
WidgetReplicator
do
let
(
:model_record
)
{
build
(
:widget
)
}
let
(
:model_record
)
{
build
(
:widget
)
}
it_behaves_like
'a blob replicator'
it_behaves_like
'a blob replicator'
...
@@ -301,7 +301,7 @@ For example, to add support for files referenced by a `Widget` model with a
...
@@ -301,7 +301,7 @@ For example, to add support for files referenced by a `Widget` model with a
require
'spec_helper'
require
'spec_helper'
describe
Geo
::
WidgetRegistry
,
:geo
,
type: :model
do
RSpec
.
describe
Geo
::
WidgetRegistry
,
:geo
,
type: :model
do
let_it_be
(
:registry
)
{
create
(
:widget_registry
)
}
let_it_be
(
:registry
)
{
create
(
:widget_registry
)
}
specify
'factory is valid'
do
specify
'factory is valid'
do
...
@@ -428,7 +428,7 @@ Widgets should now be verified by Geo!
...
@@ -428,7 +428,7 @@ Widgets should now be verified by Geo!
require
'spec_helper'
require
'spec_helper'
describe
Resolvers
::
Geo
::
WidgetRegistriesResolver
do
RSpec
.
describe
Resolvers
::
Geo
::
WidgetRegistriesResolver
do
it_behaves_like
'a Geo registries resolver'
,
:widget_registry
it_behaves_like
'a Geo registries resolver'
,
:widget_registry
end
end
```
```
...
@@ -452,7 +452,7 @@ Widgets should now be verified by Geo!
...
@@ -452,7 +452,7 @@ Widgets should now be verified by Geo!
require
'spec_helper'
require
'spec_helper'
describe
Geo
::
WidgetRegistryFinder
do
RSpec
.
describe
Geo
::
WidgetRegistryFinder
do
it_behaves_like
'a framework registry finder'
,
:widget_registry
it_behaves_like
'a framework registry finder'
,
:widget_registry
end
end
```
```
...
@@ -484,7 +484,7 @@ Widgets should now be verified by Geo!
...
@@ -484,7 +484,7 @@ Widgets should now be verified by Geo!
require
'spec_helper'
require
'spec_helper'
describe
GitlabSchema
.
types
[
'WidgetRegistry'
]
do
RSpec
.
describe
GitlabSchema
.
types
[
'WidgetRegistry'
]
do
it_behaves_like
'a Geo registry type'
it_behaves_like
'a Geo registry type'
it
'has the expected fields (other than those included in RegistryType)'
do
it
'has the expected fields (other than those included in RegistryType)'
do
...
...
doc/development/gotchas.md
View file @
5d419653
...
@@ -20,7 +20,7 @@ Consider the following API spec:
...
@@ -20,7 +20,7 @@ Consider the following API spec:
```
ruby
```
ruby
require
'spec_helper'
require
'spec_helper'
describe
API
::
Labels
do
RSpec
.
describe
API
::
Labels
do
it
'creates a first label'
do
it
'creates a first label'
do
create
(
:label
)
create
(
:label
)
...
@@ -71,7 +71,7 @@ Following is the fixed API spec:
...
@@ -71,7 +71,7 @@ Following is the fixed API spec:
```
ruby
```
ruby
require
'spec_helper'
require
'spec_helper'
describe
API
::
Labels
do
RSpec
.
describe
API
::
Labels
do
it
'creates a first label'
do
it
'creates a first label'
do
create
(
:label
,
title:
'foo'
)
create
(
:label
,
title:
'foo'
)
...
...
doc/development/testing_guide/testing_migrations_guide.md
View file @
5d419653
...
@@ -112,7 +112,7 @@ migration. You can find the complete spec in
...
@@ -112,7 +112,7 @@ migration. You can find the complete spec in
require
'spec_helper'
require
'spec_helper'
require
Rails
.
root
.
join
(
'db'
,
'post_migrate'
,
'20170526185842_migrate_pipeline_stages.rb'
)
require
Rails
.
root
.
join
(
'db'
,
'post_migrate'
,
'20170526185842_migrate_pipeline_stages.rb'
)
describe
MigratePipelineStages
do
RSpec
.
describe
MigratePipelineStages
do
# Create test data - pipeline and CI/CD jobs.
# Create test data - pipeline and CI/CD jobs.
let
(
:jobs
)
{
table
(
:ci_builds
)
}
let
(
:jobs
)
{
table
(
:ci_builds
)
}
let
(
:stages
)
{
table
(
:ci_stages
)
}
let
(
:stages
)
{
table
(
:ci_stages
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment