Merge branch 'Fix-GraphQL/OrderedArguments-offense-(Part-5/6)' into 'master'

Fix GraphQL/OrderedArguments offense (Part 5/6)

See merge request gitlab-org/gitlab!76027

.rubocop_todo/graphql/ordered_arguments.yml

@@ -4,10 +4,6 @@ GraphQL/OrderedArguments:
   - app/graphql/resolvers/base_issues_resolver.rb
   - app/graphql/resolvers/design_management/designs_resolver.rb
   - app/graphql/resolvers/design_management/version/design_at_version_resolver.rb
-  - app/graphql/types/commit_action_type.rb
-  - app/graphql/types/diff_paths_input_type.rb
-  - app/graphql/types/issues/negated_issue_filter_input_type.rb
-  - app/graphql/types/jira_users_mapping_input_type.rb
   - app/graphql/types/notes/diff_image_position_input_type.rb
   - app/graphql/types/notes/diff_position_base_input_type.rb
   - app/graphql/types/notes/diff_position_input_type.rb

app/graphql/types/commit_action_type.rb

@@ -4,17 +4,17 @@ module Types
   class CommitActionType < BaseInputObject
     argument :action, type: Types::CommitActionModeEnum, required: true,
           description: 'Action to perform: create, delete, move, update, or chmod.'
-    argument :file_path, type: GraphQL::Types::String, required: true,
-          description: 'Full path to the file.'
     argument :content, type: GraphQL::Types::String, required: false,
              description: 'Content of the file.'
-    argument :previous_path, type: GraphQL::Types::String, required: false,
-             description: 'Original full path to the file being moved.'
-    argument :last_commit_id, type: GraphQL::Types::String, required: false,
-             description: 'Last known file commit ID.'
-    argument :execute_filemode, type: GraphQL::Types::Boolean, required: false,
-             description: 'Enables/disables the execute flag on the file.'
     argument :encoding, type: Types::CommitEncodingEnum, required: false,
              description: 'Encoding of the file. Default is text.'
+    argument :execute_filemode, type: GraphQL::Types::Boolean, required: false,
+             description: 'Enables/disables the execute flag on the file.'
+    argument :file_path, type: GraphQL::Types::String, required: true,
+          description: 'Full path to the file.'
+    argument :last_commit_id, type: GraphQL::Types::String, required: false,
+             description: 'Last known file commit ID.'
+    argument :previous_path, type: GraphQL::Types::String, required: false,
+             description: 'Original full path to the file being moved.'
   end
 end

app/graphql/types/diff_paths_input_type.rb

@@ -2,9 +2,9 @@
 
 module Types
   class DiffPathsInputType < BaseInputObject
-    argument :old_path, GraphQL::Types::String, required: false,
-              description: 'Path of the file on the start SHA.'
     argument :new_path, GraphQL::Types::String, required: false,
               description: 'Path of the file on the HEAD SHA.'
+    argument :old_path, GraphQL::Types::String, required: false,
+              description: 'Path of the file on the start SHA.'
   end
 end

app/graphql/types/issues/negated_issue_filter_input_type.rb

@@ -5,6 +5,15 @@ module Types
     class NegatedIssueFilterInputType < BaseInputObject
       graphql_name 'NegatedIssueFilterInput'
 
+      argument :assignee_id, GraphQL::Types::String,
+                required: false,
+                description: 'ID of a user not assigned to the issues.'
+      argument :assignee_usernames, [GraphQL::Types::String],
+                required: false,
+                description: 'Usernames of users not assigned to the issue.'
+      argument :author_username, GraphQL::Types::String,
+                required: false,
+                description: "Username of a user who didn't author the issue."
       argument :iids, [GraphQL::Types::String],
                 required: false,
                 description: 'List of IIDs of issues to exclude. For example, `[1, 2]`.'
@@ -14,24 +23,15 @@ module Types
       argument :milestone_title, [GraphQL::Types::String],
                 required: false,
                 description: 'Milestone not applied to this issue.'
-      argument :release_tag, [GraphQL::Types::String],
-                required: false,
-                description: "Release tag not associated with the issue's milestone. Ignored when parent is a group."
-      argument :author_username, GraphQL::Types::String,
-                required: false,
-                description: "Username of a user who didn't author the issue."
-      argument :assignee_usernames, [GraphQL::Types::String],
-                required: false,
-                description: 'Usernames of users not assigned to the issue.'
-      argument :assignee_id, GraphQL::Types::String,
-                required: false,
-                description: 'ID of a user not assigned to the issues.'
       argument :milestone_wildcard_id, ::Types::NegatedMilestoneWildcardIdEnum,
                 required: false,
                 description: 'Filter by negated milestone wildcard values.'
       argument :my_reaction_emoji, GraphQL::Types::String,
                 required: false,
                 description: 'Filter by reaction emoji applied by the current user.'
+      argument :release_tag, [GraphQL::Types::String],
+                required: false,
+                description: "Release tag not associated with the issue's milestone. Ignored when parent is a group."
       argument :types, [Types::IssueTypeEnum],
                as: :issue_types,
                description: 'Filters out issues by the given issue types.',

app/graphql/types/jira_users_mapping_input_type.rb

@@ -4,13 +4,13 @@ module Types
   class JiraUsersMappingInputType < BaseInputObject
     graphql_name 'JiraUsersMappingInputType'
 
-    argument :jira_account_id,
-             GraphQL::Types::String,
-             required: true,
-             description: 'Jira account ID of the user.'
     argument :gitlab_id,
              GraphQL::Types::Int,
              required: false,
              description: 'ID of the GitLab user.'
+    argument :jira_account_id,
+             GraphQL::Types::String,
+             required: true,
+             description: 'Jira account ID of the user.'
   end
 end