Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5f814d60
Commit
5f814d60
authored
Sep 03, 2020
by
pburdette
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove warnings from pipeline view
Remove warnings from pipeline view and remove related test coverage.
parent
68dce53e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
36 deletions
+0
-36
app/views/projects/pipelines/_pipeline_warnings.html.haml
app/views/projects/pipelines/_pipeline_warnings.html.haml
+0
-9
app/views/projects/pipelines/show.html.haml
app/views/projects/pipelines/show.html.haml
+0
-1
spec/views/projects/pipelines/show.html.haml_spec.rb
spec/views/projects/pipelines/show.html.haml_spec.rb
+0
-26
No files found.
app/views/projects/pipelines/_pipeline_warnings.html.haml
deleted
100644 → 0
View file @
68dce53e
-
total_warnings
=
warnings
.
length
-
message
=
warning_header
(
total_warnings
)
-
if
warnings
.
any?
.bs-callout.bs-callout-warning
%details
%summary
.gl-mb-2
=
message
-
warnings
.
map
(
&
:content
).
each
do
|
warning
|
=
markdown
(
warning
)
app/views/projects/pipelines/show.html.haml
View file @
5f814d60
...
...
@@ -19,7 +19,6 @@
-
lint_link_start
=
'<a href="%{url}">'
.
html_safe
%
{
url:
lint_link_url
}
=
s_
(
'You can also test your %{gitlab_ci_yml} in %{lint_link_start}CI Lint%{lint_link_end}'
).
html_safe
%
{
gitlab_ci_yml:
'.gitlab-ci.yml'
,
lint_link_start:
lint_link_start
,
lint_link_end:
'</a>'
.
html_safe
}
=
render
"projects/pipelines/pipeline_warnings"
,
warnings:
@pipeline
.
warning_messages
(
limit:
Gitlab
::
Ci
::
Warnings
::
MAX_LIMIT
)
=
render
"projects/pipelines/with_tabs"
,
pipeline:
@pipeline
,
pipeline_has_errors:
pipeline_has_errors
.js-pipeline-details-vue
{
data:
{
endpoint:
project_pipeline_path
(
@project
,
@pipeline
,
format: :json
)
}
}
spec/views/projects/pipelines/show.html.haml_spec.rb
View file @
5f814d60
...
...
@@ -16,24 +16,6 @@ RSpec.describe 'projects/pipelines/show' do
stub_feature_flags
(
new_pipeline_form:
false
)
end
shared_examples
'pipeline with warning messages'
do
let
(
:warning_messages
)
do
[
double
(
content:
'warning 1'
),
double
(
content:
'warning 2'
)]
end
before
do
allow
(
pipeline
).
to
receive
(
:warning_messages
).
and_return
(
warning_messages
)
end
it
'displays the warnings'
do
render
expect
(
rendered
).
to
have_css
(
'.bs-callout-warning'
)
expect
(
rendered
).
to
have_content
(
'warning 1'
)
expect
(
rendered
).
to
have_content
(
'warning 2'
)
end
end
context
'when pipeline has errors'
do
before
do
allow
(
pipeline
).
to
receive
(
:yaml_errors
).
and_return
(
'some errors'
)
...
...
@@ -51,10 +33,6 @@ RSpec.describe 'projects/pipelines/show' do
expect
(
rendered
).
not_to
have_css
(
'ul.pipelines-tabs'
)
end
context
'when pipeline has also warnings'
do
it_behaves_like
'pipeline with warning messages'
end
end
context
'when pipeline is valid'
do
...
...
@@ -69,9 +47,5 @@ RSpec.describe 'projects/pipelines/show' do
expect
(
rendered
).
to
have_css
(
'ul.pipelines-tabs'
)
end
context
'when pipeline has warnings'
do
it_behaves_like
'pipeline with warning messages'
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment