Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6089f196
Commit
6089f196
authored
Sep 24, 2020
by
Adam Hegyi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove migrate_bio_to_user_details FF
parent
ff29fcb0
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
0 additions
and
28 deletions
+0
-28
config/feature_flags/development/migrate_bio_to_user_details.yml
...feature_flags/development/migrate_bio_to_user_details.yml
+0
-7
db/post_migrate/20200511083541_cleanup_projects_with_missing_namespace.rb
...20200511083541_cleanup_projects_with_missing_namespace.rb
+0
-2
lib/gitlab/background_migration/migrate_users_bio_to_user_details.rb
...background_migration/migrate_users_bio_to_user_details.rb
+0
-2
spec/lib/gitlab/background_migration/migrate_users_bio_to_user_details_spec.rb
...round_migration/migrate_users_bio_to_user_details_spec.rb
+0
-17
No files found.
config/feature_flags/development/migrate_bio_to_user_details.yml
deleted
100644 → 0
View file @
ff29fcb0
---
name
:
migrate_bio_to_user_details
introduced_by_url
:
rollout_issue_url
:
group
:
type
:
development
default_enabled
:
true
db/post_migrate/20200511083541_cleanup_projects_with_missing_namespace.rb
View file @
6089f196
...
...
@@ -66,8 +66,6 @@ class CleanupProjectsWithMissingNamespace < ActiveRecord::Migration[6.0]
end
def
ensure_bio_is_assigned_to_user_details
return
if
Feature
.
disabled?
(
:migrate_bio_to_user_details
,
default_enabled:
true
)
user_detail
.
bio
=
bio
.
to_s
[
0
...
255
]
end
...
...
lib/gitlab/background_migration/migrate_users_bio_to_user_details.rb
View file @
6089f196
...
...
@@ -13,8 +13,6 @@ module Gitlab
end
def
perform
(
start_id
,
stop_id
)
return
if
Feature
.
disabled?
(
:migrate_bio_to_user_details
,
default_enabled:
true
)
relation
=
User
.
select
(
"id AS user_id"
,
"substring(COALESCE(bio, '') from 1 for 255) AS bio"
)
.
where
(
"(COALESCE(bio, '') IS DISTINCT FROM '')"
)
...
...
spec/lib/gitlab/background_migration/migrate_users_bio_to_user_details_spec.rb
View file @
6089f196
...
...
@@ -82,21 +82,4 @@ RSpec.describe Gitlab::BackgroundMigration::MigrateUsersBioToUserDetails, :migra
expect
(
user_detail
).
to
be_nil
end
context
'when `migrate_bio_to_user_details` feature flag is off'
do
before
do
stub_feature_flags
(
migrate_bio_to_user_details:
false
)
end
it
'does nothing'
do
already_existing_user_details
=
user_details
.
where
(
user_id:
[
user_has_different_details
.
id
,
user_already_has_details
.
id
])
subject
expect
(
user_details
.
all
).
to
match_array
(
already_existing_user_details
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment