Commit 60f29ca3 authored by Lin Jen-Shin's avatar Lin Jen-Shin

Adopt `rules` for review-stop as well

parent 53c2d3b3
...@@ -167,10 +167,7 @@ schedule:review-deploy: ...@@ -167,10 +167,7 @@ schedule:review-deploy:
- .only-review-schedules - .only-review-schedules
.base-review-stop: .base-review-stop:
extends: extends: .review-workflow-base
- .review-workflow-base
- .only-review
- .only:changes-code-qa
environment: environment:
action: stop action: stop
variables: variables:
...@@ -187,13 +184,20 @@ schedule:review-deploy: ...@@ -187,13 +184,20 @@ schedule:review-deploy:
review-stop-failed-deployment: review-stop-failed-deployment:
extends: .base-review-stop extends: .base-review-stop
stage: prepare stage: prepare
rules:
- <<: *if-canonical-gitlab-and-merge-request
changes: *code-qa-patterns
when: on_success
script: script:
- delete_failed_release - delete_failed_release
review-stop: review-stop:
extends: .base-review-stop extends: .base-review-stop
stage: review stage: review
when: manual rules:
- <<: *if-canonical-gitlab-and-merge-request
changes: *code-qa-patterns
when: manual
allow_failure: true allow_failure: true
script: script:
- delete_release - delete_release
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment