Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
61e67b7f
Commit
61e67b7f
authored
Apr 12, 2021
by
Axel Garcia
Committed by
Amy Qualls
Apr 12, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve Snowplow Docs and Product Intelligence review guidelines
parent
acfcda47
Changes
2
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
158 additions
and
64 deletions
+158
-64
doc/development/snowplow.md
doc/development/snowplow.md
+145
-62
doc/development/usage_ping/product_intelligence_review.md
doc/development/usage_ping/product_intelligence_review.md
+13
-2
No files found.
doc/development/snowplow.md
View file @
61e67b7f
This diff is collapsed.
Click to expand it.
doc/development/usage_ping/product_intelligence_review.md
View file @
61e67b7f
...
...
@@ -34,7 +34,7 @@ Product Intelligence files.
### Roles and process
The merge request
**author**
should:
#### The merge request **author** should
-
Decide whether a Product Intelligence review is needed.
-
If a Product Intelligence review is needed, add the labels
...
...
@@ -48,7 +48,15 @@ The merge request **author** should:
[
Metrics Dictionary
](
https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/usage_ping/dictionary.md
)
if it is needed.
-
Add a changelog
[
according to guidelines
](
../changelog.md
)
.
The Product Intelligence
**reviewer**
should:
##### When adding or modifiying Snowplow events
-
For frontend events, when relevant, add a screenshot of the event in
the
[
testing tool
](
../snowplow.md#developing-and-testing-snowplow
)
used.
-
For backend events, when relevant, add the output of the Snowplow Micro
good events
`GET http://localhost:9090/micro/good`
(it might be a good idea
to reset with
`GET http://localhost:9090/micro/reset`
first).
#### The Product Intelligence **reviewer** should
-
Perform a first-pass review on the merge request and suggest improvements to the author.
-
Approve the MR, and relabel the MR with
`~"product intelligence::approved"`
.
...
...
@@ -71,6 +79,9 @@ Any of the Product Intelligence engineers can be assigned for the Product Intell
-
For tracking using Redis HLL (HyperLogLog):
-
Check the Redis slot.
-
Check if a
[
feature flag is needed
](
index.md#recommendations
)
.
-
For tracking with Snowplow:
-
Check that the
[
event taxonomy
](
../snowplow.md#structured-event-taxonomy
)
is correct.
-
Check the
[
usage recomendations
](
../snowplow.md#usage-recommendations
)
.
-
Metrics YAML definitions:
-
Check the metric
`description`
.
-
Check the metrics
`key_path`
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment