Merge branch '32094-custom-notifications-model-aria-labelledby-incorrect' into 'master'

Fix aria labels on custom notifications modal Closes #32094 See merge request !11256

Merge branch '32094-custom-notifications-model-aria-labelledby-incorrect' into 'master'
Fix aria labels on custom notifications modal Closes #32094 See merge request !11256
64d6569c · Phil Hughes · 1ccf101e · f4b6865a · 64d6569c
Commit 64d6569c authored May 11, 2017 by Phil Hughes
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

app/views/shared/notifications/_custom_notifications.html.haml ...iews/shared/notifications/_custom_notifications.html.haml +3 -3

No files found.
--- a/app/views/shared/notifications/_custom_notifications.html.haml
+++ b/app/views/shared/notifications/_custom_notifications.html.haml
-.modal.fade{ tabindex: "-1", role: "dialog", id: notifications_menu_identifier("modal", notification_setting), aria: { labelledby: "custom-notifications-title" } }
+.modal.fade{ tabindex: "-1", role: "dialog", id: notifications_menu_identifier("modal", notification_setting), "aria-labelledby": "custom-notifications-title" }
  .modal-dialog
    .modal-content
      .modal-header
-        %button.close{ type: "button", data: { dismiss: "modal" }, aria: { label: "close" } }
-          %span{ aria: { hidden: "true" } } ×
+        %button.close{ type: "button",  "aria-label": "close", data: { dismiss: "modal" } }
+          %span{ "aria-hidden": "true" } } ×
        %h4#custom-notifications-title.modal-title
          Custom notification events