Commit 66397ac4 authored by Nathan Friend's avatar Nathan Friend

Fix cancel button on New Release page

This commit fixes the "Cancel" button at the bottom of the New Release
page by ensuring the button's href is provided by the backend.
parent cd36b8c8
......@@ -6,9 +6,9 @@ export default ({
releaseAssetsDocsPath,
manageMilestonesPath,
newMilestonePath,
releasesPagePath,
tagName = null,
releasesPagePath = null,
defaultBranch = null,
}) => ({
projectId,
......@@ -18,6 +18,7 @@ export default ({
releaseAssetsDocsPath,
manageMilestonesPath,
newMilestonePath,
releasesPagePath,
/**
* The name of the tag associated with the release, provided by the backend.
......@@ -25,7 +26,6 @@ export default ({
*/
tagName,
releasesPagePath,
defaultBranch,
createFrom: defaultBranch,
......
......@@ -37,7 +37,8 @@ module ReleasesHelper
def data_for_new_release_page
new_edit_pages_shared_data.merge(
default_branch: @project.default_branch
default_branch: @project.default_branch,
releases_page_path: project_releases_path(@project)
)
end
......
---
title: Fix cancel button on New Release page
merge_request: 39144
author:
type: fixed
......@@ -80,6 +80,7 @@ RSpec.describe ReleasesHelper do
describe '#data_for_new_release_page' do
it 'has the needed data to display the "new release" page' do
keys = %i(project_id
releases_page_path
markdown_preview_path
markdown_docs_path
update_release_api_docs_path
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment