Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
664a5664
Commit
664a5664
authored
Nov 13, 2019
by
Olivier Gonzalez
Committed by
Robert Speicher
Nov 13, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Documentation - Clarify default feature flag for all instances
parent
37ca74ac
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
10 deletions
+6
-10
doc/development/feature_flags/development.md
doc/development/feature_flags/development.md
+6
-10
No files found.
doc/development/feature_flags/development.md
View file @
664a5664
...
@@ -52,20 +52,16 @@ isn't gated by a License or Plan.
...
@@ -52,20 +52,16 @@ isn't gated by a License or Plan.
[
namespace-fa
]:
https://gitlab.com/gitlab-org/gitlab/blob/4cc1c62918aa4c31750cb21dfb1a6c3492d71080/ee/app/models/ee/namespace.rb#L71-85
[
namespace-fa
]:
https://gitlab.com/gitlab-org/gitlab/blob/4cc1c62918aa4c31750cb21dfb1a6c3492d71080/ee/app/models/ee/namespace.rb#L71-85
[
license-fa
]:
https://gitlab.com/gitlab-org/gitlab/blob/4cc1c62918aa4c31750cb21dfb1a6c3492d71080/ee/app/models/license.rb#L293-300
[
license-fa
]:
https://gitlab.com/gitlab-org/gitlab/blob/4cc1c62918aa4c31750cb21dfb1a6c3492d71080/ee/app/models/license.rb#L293-300
An important side-effect of the implicit feature flags mentioned above is that
**
An important side-effect of the implicit feature flags mentioned above is that
unless the feature is explicitly disabled or limited to a percentage of users,
unless the feature is explicitly disabled or limited to a percentage of users,
the feature flag check will default to
`true`
.
the feature flag check will default to
`true`
.
**
As an example, if you were to ship the backend half of a feature behind a flag,
As an example, if you were to ship the backend half of a feature behind a flag,
you'd want to explicitly disable that flag until the frontend half is also ready
you'd want to explicitly disable that flag until the frontend half is also ready
to be shipped.
[
You can do this via Chatops
](
controls.md
)
:
to be shipped. To make sure this feature is disabled for both GitLab.com and
self-managed instances you'd need to explicitly call
`Feature.enabled?`
method
```
before the
`feature_available`
method. This ensures the feature_flag is defaulting
/chatops run feature set some_feature 0
to
`true`
.
```
Note that you can do this at any time, even before the merge request using the
flag has been merged!
## Feature groups
## Feature groups
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment