Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
66550172
Commit
66550172
authored
Aug 24, 2020
by
Illya Klymov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace isEmpty() assertion with html()
@vue/test-utils deprecates isEmpty() We replace it with .html()
parent
e8c7d7ed
Changes
11
Hide whitespace changes
Inline
Side-by-side
Showing
11 changed files
with
11 additions
and
11 deletions
+11
-11
ee/spec/frontend/approvals/components/mr_edit/mr_rules_hidden_inputs_spec.js
...provals/components/mr_edit/mr_rules_hidden_inputs_spec.js
+1
-1
ee/spec/frontend/dast_profiles/components/dast_profiles_list_spec.js
...ntend/dast_profiles/components/dast_profiles_list_spec.js
+1
-1
ee/spec/frontend/vue_mr_widget/components/blocking_merge_requests/blocking_merge_requests_report_spec.js
...ing_merge_requests/blocking_merge_requests_report_spec.js
+1
-1
ee/spec/frontend/vue_shared/components/security_reports/severity_badge_spec.js
...shared/components/security_reports/severity_badge_spec.js
+1
-1
spec/frontend/clusters_list/components/ancestor_notice_spec.js
...frontend/clusters_list/components/ancestor_notice_spec.js
+1
-1
spec/frontend/ide/components/terminal/session_spec.js
spec/frontend/ide/components/terminal/session_spec.js
+1
-1
spec/frontend/ide/components/terminal_sync/terminal_sync_status_spec.js
...ide/components/terminal_sync/terminal_sync_status_spec.js
+1
-1
spec/frontend/notes/components/discussion_filter_spec.js
spec/frontend/notes/components/discussion_filter_spec.js
+1
-1
spec/frontend/performance_bar/components/detailed_metric_spec.js
...ontend/performance_bar/components/detailed_metric_spec.js
+1
-1
spec/frontend/performance_bar/components/request_warning_spec.js
...ontend/performance_bar/components/request_warning_spec.js
+1
-1
spec/frontend/vue_shared/components/table_pagination_spec.js
spec/frontend/vue_shared/components/table_pagination_spec.js
+1
-1
No files found.
ee/spec/frontend/approvals/components/mr_edit/mr_rules_hidden_inputs_spec.js
View file @
66550172
...
...
@@ -62,7 +62,7 @@ describe('EE Approvlas MRRulesHiddenInputs', () => {
it
(
'
is empty
'
,
()
=>
{
factory
();
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
...
...
ee/spec/frontend/dast_profiles/components/dast_profiles_list_spec.js
View file @
66550172
...
...
@@ -188,7 +188,7 @@ describe('EE - DastProfilesList', () => {
getDeleteButtonWithin
(
getTableRowForProfile
(
profile
));
it
(
'
opens a modal with the correct title when a delete button is clicked
'
,
async
()
=>
{
expect
(
getModal
().
isEmpty
()).
toBe
(
true
);
expect
(
getModal
().
html
()).
toBe
(
''
);
getCurrentProfileDeleteButton
().
trigger
(
'
click
'
);
...
...
ee/spec/frontend/vue_mr_widget/components/blocking_merge_requests/blocking_merge_requests_report_spec.js
View file @
66550172
...
...
@@ -48,7 +48,7 @@ describe('BlockingMergeRequestsReport', () => {
props
.
mr
.
blockingMergeRequests
.
visible_merge_requests
=
{};
createComponent
(
props
);
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
it
(
'
passes merged MRs as resolved issues and anything else as unresolved
'
,
()
=>
{
...
...
ee/spec/frontend/vue_shared/components/security_reports/severity_badge_spec.js
View file @
66550172
...
...
@@ -60,7 +60,7 @@ describe('Severity Badge', () => {
});
it
(
`renders an empty component`
,
()
=>
{
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
});
spec/frontend/clusters_list/components/ancestor_notice_spec.js
View file @
66550172
...
...
@@ -28,7 +28,7 @@ describe('ClustersAncestorNotice', () => {
});
it
(
'
displays no notice
'
,
()
=>
{
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
...
...
spec/frontend/ide/components/terminal/session_spec.js
View file @
66550172
...
...
@@ -52,7 +52,7 @@ describe('IDE TerminalSession', () => {
state
.
session
=
null
;
factory
();
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
it
(
'
shows terminal
'
,
()
=>
{
...
...
spec/frontend/ide/components/terminal_sync/terminal_sync_status_spec.js
View file @
66550172
...
...
@@ -58,7 +58,7 @@ describe('ide/components/terminal_sync/terminal_sync_status', () => {
it
(
'
shows nothing
'
,
()
=>
{
createComponent
();
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
...
...
spec/frontend/notes/components/discussion_filter_spec.js
View file @
66550172
...
...
@@ -150,7 +150,7 @@ describe('DiscussionFilter component', () => {
eventHub
.
$emit
(
'
MergeRequestTabChange
'
,
'
commit
'
);
wrapper
.
vm
.
$nextTick
(()
=>
{
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
done
();
});
});
...
...
spec/frontend/performance_bar/components/detailed_metric_spec.js
View file @
66550172
...
...
@@ -30,7 +30,7 @@ describe('detailedMetric', () => {
});
it
(
'
does not render the element
'
,
()
=>
{
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
...
...
spec/frontend/performance_bar/components/request_warning_spec.js
View file @
66550172
...
...
@@ -27,7 +27,7 @@ describe('request warning', () => {
});
it
(
'
does nothing
'
,
()
=>
{
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
});
spec/frontend/vue_shared/components/table_pagination_spec.js
View file @
66550172
...
...
@@ -34,7 +34,7 @@ describe('Pagination component', () => {
change
:
spy
,
});
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
it
(
'
renders if there is a next page
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment