Merge branch...

Merge branch '33019-refactor-spec-features-help_pages_spec-rb-to-not-rely-on-the-docs-content' into 'master'

Don't rely on 'doc/README.md' in 'spec/features/help_pages_spec.rb'

Closes #33019

See merge request gitlab-org/gitlab!31078

.gitlab/ci/rules.gitlab-ci.yml

@@ -83,7 +83,6 @@
   - "{,ee/}fixtures/**/*"
   - "{,ee/}rubocop/**/*"
   - "{,ee/}spec/**/*"
-  - "doc/README.md"  # Some RSpec test rely on this file
 
 .code-patterns: &code-patterns
   - "{package.json,yarn.lock}"
@@ -126,7 +125,6 @@
   - "{,ee/}fixtures/**/*"
   - "{,ee/}rubocop/**/*"
   - "{,ee/}spec/**/*"
-  - "doc/README.md"  # Some RSpec test rely on this file
 
 .code-qa-patterns: &code-qa-patterns
   - "{package.json,yarn.lock}"
@@ -168,7 +166,6 @@
   - "{,ee/}fixtures/**/*"
   - "{,ee/}rubocop/**/*"
   - "{,ee/}spec/**/*"
-  - "doc/README.md"  # Some RSpec test rely on this file
   # QA changes
   - ".dockerignore"
   - "qa/**/*"

doc/development/documentation/index.md

@@ -405,8 +405,6 @@ merge request with new or changed docs is submitted, are:
     - [`internal_anchors`](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/ci/docs.gitlab-ci.yml#L69)
       checks that all internal anchors (ex: `[link](../index.md#internal_anchor)`)
       are valid.
-- If any code or the `doc/README.md` file is changed, a full pipeline will run, which
-  runs tests for [`/help`](#gitlab-help-tests).
 
 ### Running tests
 

spec/features/help_pages_spec.rb

@@ -4,35 +4,9 @@ require 'spec_helper'
 
 describe 'Help Pages' do
   describe 'Get the main help page' do
-    shared_examples_for 'help page' do |prefix: ''|
-      it 'prefixes links correctly' do
-        expect(page).to have_selector(%(div.documentation-index > table tbody tr td a[href="#{prefix}/help/api/README.md"]))
-      end
-    end
-
-    context 'without a trailing slash' do
-      before do
-        visit help_path
-      end
-
-      it_behaves_like 'help page'
-    end
-
-    context 'with a trailing slash' do
-      before do
-        visit help_path + '/'
-      end
-
-      it_behaves_like 'help page'
-    end
-
-    context 'with a relative installation' do
-      before do
-        stub_config_setting(relative_url_root: '/gitlab')
-        visit help_path
-      end
-
-      it_behaves_like 'help page', prefix: '/gitlab'
+    before do
+      allow(File).to receive(:read).and_call_original
+      allow(File).to receive(:read).with(Rails.root.join('doc', 'README.md')).and_return(fixture_file('sample_doc.md'))
     end
 
     context 'quick link shortcuts', :js do

spec/fixtures/sample_doc.md

+[GitLab API](api/README.md)