Merge branch 'afontaine/remove-group_ci_cd_analytics_page' into 'master'

Remove group_ci_cd_analytics_page

See merge request gitlab-org/gitlab!83033

config/feature_flags/development/group_ci_cd_analytics_page.yml

----
-name: group_ci_cd_analytics_page
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/49608
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/292601
-milestone: '13.8'
-type: development
-group: group::release
-default_enabled: true

ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb

@@ -8,6 +8,5 @@ class Groups::Analytics::CiCdAnalyticsController < Groups::Analytics::Applicatio
   before_action -> { authorize_view_by_action!(:view_group_ci_cd_analytics) }
 
   def show
-    render_404 unless Feature.enabled?(:group_ci_cd_analytics_page, @group, default_enabled: true)
   end
 end

ee/lib/sidebars/groups/menus/analytics_menu.rb

@@ -62,7 +62,6 @@ module Sidebars
 
         def show_ci_cd_analytics?
           context.group.licensed_feature_available?(:group_ci_cd_analytics) &&
-          ::Feature.enabled?(:group_ci_cd_analytics_page, context.group, default_enabled: true) &&
           can?(context.current_user, :view_group_ci_cd_analytics, context.group)
         end
 

ee/spec/controllers/groups/analytics/ci_cd_analytics_controller_spec.rb

@@ -17,7 +17,6 @@ RSpec.describe Groups::Analytics::CiCdAnalyticsController do
 
   before do
     stub_licensed_features(group_ci_cd_analytics: true)
-    stub_feature_flags(group_ci_cd_analytics_page: true)
 
     sign_in(current_user) if current_user
   end
@@ -72,17 +71,5 @@ RSpec.describe Groups::Analytics::CiCdAnalyticsController do
 
       it_behaves_like 'returns a 403'
     end
-
-    context "when the :group_ci_cd_analytics_page feature flag is disabled" do
-      before do
-        stub_feature_flags(group_ci_cd_analytics_page: false)
-      end
-
-      it 'returns a 404' do
-        make_request
-
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
   end
 end

ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb

@@ -57,14 +57,6 @@ RSpec.describe Sidebars::Groups::Menus::AnalyticsMenu do
         end
       end
 
-      describe 'when feature flag :group_ci_cd_analytics_page is disabled' do
-        specify do
-          stub_feature_flags(group_ci_cd_analytics_page: false)
-
-          is_expected.to be_nil
-        end
-      end
-
       describe 'when the user does not have access' do
         let(:user) { nil }