Merge branch '294004-enable-jira-sync-builds' into 'master'

Remove jira_sync_builds feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!51627

app/models/ci/pipeline.rb

@@ -262,8 +262,6 @@ module Ci
       end
 
       after_transition any => any do |pipeline|
-        next unless Feature.enabled?(:jira_sync_builds, pipeline.project)
-
         pipeline.run_after_commit do
           # Passing the seq-id ensures this is idempotent
           seq_id = ::Atlassian::JiraConnect::Client.generate_update_sequence_id

app/workers/jira_connect/sync_builds_worker.rb

@@ -14,7 +14,6 @@ module JiraConnect
       pipeline = Ci::Pipeline.find_by_id(pipeline_id)
 
       return unless pipeline
-      return unless Feature.enabled?(:jira_sync_builds, pipeline.project)
 
       ::JiraConnect::SyncService
         .new(pipeline.project)

changelogs/unreleased/294004-enable-jira-sync-builds.yml

+---
+title: Sync pipeline builds to Jira
+merge_request: 51627
+author:
+type: added

config/feature_flags/development/jira_sync_builds.yml

----
-name: jira_sync_builds
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/49348
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/292013
-milestone: '13.7'
-type: development
-group: group::ecosystem
-default_enabled: false

lib/atlassian/jira_connect/client.rb

@@ -67,8 +67,6 @@ module Atlassian
       end
 
       def store_build_info(project:, pipelines:, update_sequence_id: nil)
-        return unless Feature.enabled?(:jira_sync_builds, project)
-
         builds = pipelines.map do |pipeline|
           build = ::Atlassian::JiraConnect::Serializers::BuildEntity.represent(
             pipeline,

spec/lib/atlassian/jira_connect/client_spec.rb

@@ -368,24 +368,6 @@ RSpec.describe Atlassian::JiraConnect::Client do
       subject.send(:store_build_info, project: project, pipelines: pipelines.take(1))
     end
 
-    it 'does not call the API if the feature flag is not enabled' do
-      stub_feature_flags(jira_sync_builds: false)
-
-      expect(subject).not_to receive(:post)
-
-      subject.send(:store_build_info, project: project, pipelines: pipelines)
-    end
-
-    it 'does call the API if the feature flag enabled for the project' do
-      stub_feature_flags(jira_sync_builds: project)
-
-      expect(subject).to receive(:post)
-        .with('/rest/builds/0.1/bulk', { builds: Array })
-        .and_call_original
-
-      subject.send(:store_build_info, project: project, pipelines: pipelines)
-    end
-
     context 'there are errors' do
       let(:failures) do
         [{ errors: [{ message: 'X' }, { message: 'Y' }] }, { errors: [{ message: 'Z' }] }]

spec/models/ci/pipeline_spec.rb

@@ -1261,26 +1261,6 @@ RSpec.describe Ci::Pipeline, :mailer, factory_default: :keep do
 
             pipeline.send(event)
           end
-
-          context 'the feature is disabled' do
-            it 'does not trigger a worker' do
-              stub_feature_flags(jira_sync_builds: false)
-
-              expect(worker).not_to receive(:perform_async)
-
-              pipeline.send(event)
-            end
-          end
-
-          context 'the feature is enabled for this project' do
-            it 'does trigger a worker' do
-              stub_feature_flags(jira_sync_builds: pipeline.project)
-
-              expect(worker).to receive(:perform_async)
-
-              pipeline.send(event)
-            end
-          end
         end
       end
     end

spec/workers/jira_connect/sync_builds_worker_spec.rb

@@ -32,29 +32,5 @@ RSpec.describe ::JiraConnect::SyncBuildsWorker do
         subject
       end
     end
-
-    context 'when the feature flag is disabled' do
-      before do
-        stub_feature_flags(jira_sync_builds: false)
-      end
-
-      it 'does not call the sync service' do
-        expect_next(::JiraConnect::SyncService).not_to receive(:execute)
-
-        subject
-      end
-    end
-
-    context 'when the feature flag is enabled for this project' do
-      before do
-        stub_feature_flags(jira_sync_builds: pipeline.project)
-      end
-
-      it 'calls the sync service' do
-        expect_next(::JiraConnect::SyncService).to receive(:execute)
-
-        subject
-      end
-    end
   end
 end