Commit 6afa879a authored by Alex Kalderimis's avatar Alex Kalderimis

Add pending examples for -code

This documents that we accidentally support `project-N-project` but want
to support `project-N-code` instead.
parent 44f9ec35
...@@ -15,11 +15,13 @@ describe Gitlab::GlRepository::Identifier do ...@@ -15,11 +15,13 @@ describe Gitlab::GlRepository::Identifier do
let(:expected_type) { Gitlab::GlRepository::PROJECT } let(:expected_type) { Gitlab::GlRepository::PROJECT }
end end
it_behaves_like 'parsing gl_repository identifier' do pending 'https://gitlab.com/gitlab-org/gitlab/-/issues/219192' do
let(:record_id) { project.id } it_behaves_like 'parsing gl_repository identifier' do
let(:identifier) { "project-#{record_id}-project" } let(:record_id) { project.id }
let(:expected_container) { project } let(:identifier) { "project-#{record_id}-code" }
let(:expected_type) { Gitlab::GlRepository::PROJECT } let(:expected_container) { project }
let(:expected_type) { Gitlab::GlRepository::PROJECT }
end
end end
it_behaves_like 'parsing gl_repository identifier' do it_behaves_like 'parsing gl_repository identifier' do
...@@ -90,7 +92,14 @@ describe Gitlab::GlRepository::Identifier do ...@@ -90,7 +92,14 @@ describe Gitlab::GlRepository::Identifier do
end end
with_them do with_them do
it_behaves_like 'illegal gl_identifier' it 'raises InvalidIdentifier' do
expect { described_class.parse(identifier) }.to raise_error(described_class::InvalidIdentifier)
end
end
it 'raises InvalidIdentifier on project-1-project' do
pending 'https://gitlab.com/gitlab-org/gitlab/-/issues/219192'
expect { described_class.parse('project-1-project') }.to raise_error(described_class::InvalidIdentifier)
end end
end end
end end
...@@ -10,9 +10,3 @@ RSpec.shared_examples 'parsing gl_repository identifier' do ...@@ -10,9 +10,3 @@ RSpec.shared_examples 'parsing gl_repository identifier' do
) )
end end
end end
RSpec.shared_examples 'illegal gl_identifier' do
it 'raises an error' do
expect { described_class.parse(identifier) }.to raise_error(described_class::InvalidIdentifier)
end
end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment