Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6b007a60
Commit
6b007a60
authored
Dec 14, 2021
by
Nourdin el Bacha
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix expose status in Runners API
Fixes
https://gitlab.com/gitlab-org/gitlab/-/issues/348438
Changelog: fixed
parent
afe8a66c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
1 deletion
+2
-1
lib/api/entities/ci/runner.rb
lib/api/entities/ci/runner.rb
+1
-1
spec/requests/api/ci/runners_spec.rb
spec/requests/api/ci/runners_spec.rb
+1
-0
No files found.
lib/api/entities/ci/runner.rb
View file @
6b007a60
...
...
@@ -14,7 +14,7 @@ module API
expose
:online?
,
as: :online
# DEPRECATED
# TODO Remove in %15.0 in favor of `status` for REST calls, see https://gitlab.com/gitlab-org/gitlab/-/issues/344648
expose
:
status
,
as: :deprecated_rest_
status
expose
:
deprecated_rest_status
,
as: :
status
end
end
end
...
...
spec/requests/api/ci/runners_spec.rb
View file @
6b007a60
...
...
@@ -254,6 +254,7 @@ RSpec.describe API::Ci::Runners do
expect
(
response
).
to
have_gitlab_http_status
(
:ok
)
expect
(
json_response
[
'description'
]).
to
eq
(
shared_runner
.
description
)
expect
(
json_response
[
'maximum_timeout'
]).
to
be_nil
expect
(
json_response
[
'status'
]).
to
eq
(
"not_connected"
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment