Ensure that tmp pages archive is removed

app/services/pages/migrate_legacy_storage_to_deployment_service.rb

@@ -44,6 +44,8 @@ module Pages
          Feature.enabled?(:pages_migration_mark_as_not_deployed, project)
         project.mark_pages_as_not_deployed
       end
+    ensure
+      FileUtils.rm_f(archive_path) if archive_path
     end
   end
 end

spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb

@@ -34,6 +34,23 @@ RSpec.describe Pages::MigrateLegacyStorageToDeploymentService do
     end.not_to change { project.pages_metadatum.reload.deployed }.from(true)
   end
 
+  it 'removes pages archive when can not save deployment' do
+    archive = fixture_file_upload("spec/fixtures/pages.zip")
+    expect_next_instance_of(::Pages::ZipDirectoryService) do |zip_service|
+      expect(zip_service).to receive(:execute).and_return([archive.path, 3])
+    end
+
+    expect_next_instance_of(PagesDeployment) do |deployment|
+      expect(deployment).to receive(:save!).and_raise("Something")
+    end
+
+    expect do
+      service.execute
+    end.to raise_error("Something")
+
+    expect(File.exist?(archive.path)).to eq(false)
+  end
+
   context 'when pages site is deployed to legacy storage' do
     before do
       FileUtils.mkdir_p File.join(project.pages_path, "public")
@@ -58,6 +75,12 @@ RSpec.describe Pages::MigrateLegacyStorageToDeploymentService do
       expect(deployment.file_sha256).to eq(Digest::SHA256.file(deployment.file.path).hexdigest)
     end
 
+    it 'removes tmp pages archive' do
+      described_class.new(project).execute
+
+      expect(File.exist?(File.join(project.pages_path, '@migrated.zip'))).to eq(false)
+    end
+
     it 'does not change pages deployment if it is set' do
       old_deployment = create(:pages_deployment, project: project)
       project.update_pages_deployment!(old_deployment)