Merge branch '336280-remove-ci_store_trace_outside_transaction-ff' into 'master'

Remove ci_store_trace_outside_transaction feature flag

See merge request gitlab-org/gitlab!78465

app/models/ci/job_artifact.rb

@@ -348,9 +348,7 @@ module Ci
 
     def store_after_commit?
       strong_memoize(:store_after_commit) do
-        trace? &&
-          JobArtifactUploader.direct_upload_enabled? &&
-          Feature.enabled?(:ci_store_trace_outside_transaction, project, default_enabled: :yaml)
+        trace? && JobArtifactUploader.direct_upload_enabled?
       end
     end
 

config/feature_flags/development/ci_store_trace_outside_transaction.yml

----
-name: ci_store_trace_outside_transaction
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/66203
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/336280
-milestone: '14.5'
-type: development
-group: group::pipeline execution
-default_enabled: true

spec/models/ci/job_artifact_spec.rb

@@ -545,20 +545,8 @@ RSpec.describe Ci::JobArtifact do
       context 'when the artifact is a trace' do
         let(:file_type) { :trace }
 
-        context 'when ci_store_trace_outside_transaction is enabled' do
-          it 'returns true' do
-            expect(artifact.store_after_commit?).to be_truthy
-          end
-        end
-
-        context 'when ci_store_trace_outside_transaction is disabled' do
-          before do
-            stub_feature_flags(ci_store_trace_outside_transaction: false)
-          end
-
-          it 'returns false' do
-            expect(artifact.store_after_commit?).to be_falsey
-          end
+        it 'returns true' do
+          expect(artifact.store_after_commit?).to be_truthy
         end
       end