Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6f4884dc
Commit
6f4884dc
authored
Jul 08, 2020
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't skip cached queries in a N+1 test
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
03603d33
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
spec/controllers/concerns/renders_commits_spec.rb
spec/controllers/concerns/renders_commits_spec.rb
+1
-1
No files found.
spec/controllers/concerns/renders_commits_spec.rb
View file @
6f4884dc
...
...
@@ -46,7 +46,7 @@ RSpec.describe RendersCommits do
it
'avoids N + 1'
do
stub_const
(
"MergeRequestDiff::COMMITS_SAFE_SIZE"
,
5
)
control_count
=
ActiveRecord
::
QueryRecorder
.
new
(
skip_cached:
false
)
do
control_count
=
ActiveRecord
::
QueryRecorder
.
new
do
go
end
.
count
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment