Merge branch 'issue_232496_2' into 'master'

Simplify third party container repository delete tags services

See merge request gitlab-org/gitlab!81184

app/services/projects/container_repository/third_party/delete_tags_service.rb

@@ -33,7 +33,7 @@ module Projects
           if deleted_tags.any? && @container_repository.delete_tag_by_digest(deleted_tags.each_value.first)
             success(deleted: deleted_tags.keys)
           else
-            error('could not delete tags')
+            error("could not delete tags: #{@tag_names.join(', ')}".truncate(1000))
           end
         end
 

spec/services/projects/container_repository/third_party/delete_tags_service_spec.rb

@@ -58,7 +58,19 @@ RSpec.describe Projects::ContainerRepository::ThirdParty::DeleteTagsService do
               stub_put_manifest_request('Ba', 500, {})
             end
 
-            it { is_expected.to eq(status: :error, message: 'could not delete tags') }
+            it { is_expected.to eq(status: :error, message: "could not delete tags: #{tags.join(', ')}")}
+
+            context 'when a large list of tag updates fails' do
+              let(:tags) { Array.new(1000) { |i| "tag_#{i}" } }
+
+              before do
+                expect(service).to receive(:replace_tag_manifests).and_return({})
+              end
+
+              it 'truncates the log message' do
+                expect(subject).to eq(status: :error, message: "could not delete tags: #{tags.join(', ')}".truncate(1000))
+              end
+            end
           end
 
           context 'a single tag update fails' do