Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6fc05683
Commit
6fc05683
authored
Feb 22, 2021
by
Yogi
Committed by
Nicolò Maria Mezzopera
Feb 22, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add label to toggle in edit_feature_flag.vue
parent
fe4ba437
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
17 additions
and
0 deletions
+17
-0
app/assets/javascripts/feature_flags/components/edit_feature_flag.vue
...avascripts/feature_flags/components/edit_feature_flag.vue
+2
-0
changelogs/unreleased/300443-add-label.yml
changelogs/unreleased/300443-add-label.yml
+5
-0
locale/gitlab.pot
locale/gitlab.pot
+3
-0
spec/frontend/feature_flags/components/edit_feature_flag_spec.js
...ontend/feature_flags/components/edit_feature_flag_spec.js
+7
-0
No files found.
app/assets/javascripts/feature_flags/components/edit_feature_flag.vue
View file @
6fc05683
...
...
@@ -86,6 +86,8 @@ export default {
data-track-event=
"click_button"
data-track-label=
"feature_flag_toggle"
class=
"gl-mr-4"
:label=
"__('Feature flag status')"
label-position=
"hidden"
@
change=
"toggleActive"
/>
<h3
class=
"page-title gl-m-0"
>
{{
title
}}
</h3>
...
...
changelogs/unreleased/300443-add-label.yml
0 → 100644
View file @
6fc05683
---
title
:
Add GlToggle label in edit feature flag
merge_request
:
54546
author
:
Yogi (@yo)
type
:
changed
locale/gitlab.pot
View file @
6fc05683
...
...
@@ -12575,6 +12575,9 @@ msgstr ""
msgid "Feature flag is not enabled on the environment's project."
msgstr ""
msgid "Feature flag status"
msgstr ""
msgid "Feature flag was not removed."
msgstr ""
...
...
spec/frontend/feature_flags/components/edit_feature_flag_spec.js
View file @
6fc05683
...
...
@@ -150,5 +150,12 @@ describe('Edit feature flag form', () => {
label
:
'
feature_flag_toggle
'
,
});
});
it
(
'
should render the toggle with a visually hidden label
'
,
()
=>
{
expect
(
wrapper
.
find
(
GlToggle
).
props
()).
toMatchObject
({
label
:
'
Feature flag status
'
,
labelPosition
:
'
hidden
'
,
});
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment